Add symbolize feature for online symbolization
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
erikgrinaker
force-pushed
the
symbolize
branch
3 times, most recently
from
3e91fa8 to
f825061
Compare
This patch adds a `symbolize` feature which performs online symbolization of profiles using the `backtrace` crate. This is often much more convenient than having to manually obtain binaries and symbolize the profiles, and matches the behavior of e.g. the `pprof-rs` CPU profiler. It will also allow emitting e.g. flamegraph SVGs directly, which I'll submit in a follow-up PR. Online symbolization uses a fair amount of memory for symbol caches, but this is often a worthwhile tradeoff.
erikgrinaker
force-pushed
the
symbolize
branch
from
f825061 to
0b146a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
symbolizefeature which performs online symbolization of profiles using thebacktracecrate.This is often much more convenient than having to manually obtain binaries and symbolize the profiles, and matches the behavior of e.g. the
pprof-rsCPU profiler. It will also allow emitting e.g. flamegraph SVGs directly, which I'll submit in a follow-up PR.Online symbolization uses a fair amount of memory for symbol caches, but this is often a worthwhile tradeoff.