Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrappings of PH to use parent_object and parent_object_property correctly #57

Closed
2 of 4 tasks
polcak opened this issue Jun 11, 2020 · 5 comments
Closed
2 of 4 tasks

Fix wrappings of PH to use parent_object and parent_object_property correctly #57

polcak opened this issue Jun 11, 2020 · 5 comments
Labels
code enhancement

Comments

@polcak
Copy link
Owner

polcak commented Jun 11, 2020 •
edited
Loading

E.g. "window.PerformanceEntry" actually modifies "PerformanceEntry.startTime" and "PerformanceEntry.duration"

  • Create wiki docs explaining the reasoning behind wrapping objects and explain the properties
  • Do not use original_functions in S-HRT
  • Fix the code
  • Make sure that wiki is still up-to-date

Current implementation introduce inconsistencies, does not go through code builders dealing with FF bug 1267027 (#25) and accesses original_functions that will make future modifications of this function harder.
@polcak polcak added the bug Something isn't working label Jun 11, 2020
@polcak
Copy link
Owner Author

polcak commented Jun 12, 2020

See wiki https://github.com/polcak/jsrestrictor/wiki/How-to-write-a-new-wrapper%3F

polcak added a commit that referenced this issue Jun 12, 2020
@polcak
Remove window.PerformanceEntry wrapping
fc25314 
In reality it was PerformanceEntry.startTime and
PerformanceEntry.duration wrapping, see #57.

Testing page https://www.fit.vutbr.cz/~ipolcak/firefox_csp_bug/nocsp.php
is not influenced by the wrapping. It is unclear when is the wrapping
applied.
@polcak
Copy link
Owner Author

polcak commented Jun 12, 2020

fc25314 removes the wrapping of window.PerformanceEntry as S-PT2 already provides fake PerformanceEntries.

I am waiting for @PeetHornak but it is possible that this can be closed as is.

@polcak polcak added code enhancement and removed bug Something isn't working labels Jun 12, 2020
@polcak polcak mentioned this issue Jun 12, 2020
Closed
@polcak
Copy link
Owner Author

polcak commented Jun 21, 2020

PerformanceEntry re-introduced as a part of #61 with rewritten code.

@polcak
Copy link
Owner Author

polcak commented Jan 14, 2021

Although there is no confirmation by @PeetHornak, I think that we can close the issue

@polcak polcak closed this as completed Jan 14, 2021
@PeetHornak
Copy link

My apologies, forgot about this one. Yes it can be closed because of the reasons you described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@polcak @PeetHornak