Versioning and pypi upload ? #33

octomike · 2019-10-16T09:46:47Z

For new users it's a bit confusing to see what version to use. Pypi only has 1.0.0 (which is old and still uses python2), Github releases only list 1.0.0 and 1.1.0 and setup.py contains version string 2.0.

A new 2.0 (pre) release(?), a tag and an upload to pypi would be super helpful for us :)

The text was updated successfully, but these errors were encountered:

vsoch · 2019-10-16T12:55:39Z

Totally agree, +1 on this one. 2.0 also is not using semantic versioning, which is important to do.

ofgulban · 2019-10-30T15:15:00Z

+1. It would also be good to know who are the active maintainers, @chrisgorgo @effigies ? I am time to time getting emails about errors etc. although I am not a maintainer. I would be willing to help tidying things up if you add me as a collaborator.

vsoch · 2019-10-30T15:17:43Z

I left the lab when I graduated in 2016 so I wouldn't be the right fit, and I know @chrisgorgo is now at Google, so he likely can't take it on. Pinging @rwblair and @oesteban who will likely know!

effigies · 2019-10-30T15:33:23Z

Looks like @poldrack is the maintainer on PyPI, so he'll need to either upload a 1.1.0 package or add maintainers.

As someone with essentially no connection to this project, I would be 👍 for adding @ofgulban as a maintainer on the strength of #15.

poldrack · 2019-10-30T19:45:13Z

if @ofgulban is happy to do that then I'm happy to add him

…

On Wed, Oct 30, 2019 at 8:34 AM Chris Markiewicz ***@***.***> wrote: Looks like @poldrack <https://github.com/poldrack> is the maintainer on PyPI <https://pypi.org/project/pydeface/>, so he'll need to either upload a 1.1.0 package or add maintainers. As someone with essentially no connection to this project, I would be 👍 for adding @ofgulban <https://github.com/ofgulban> as a maintainer on the strength of #15 <#15>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33?email_source=notifications&email_token=AAGUVECATG7TJTV35MQESA3QRGSPZA5CNFSM4JBI7TA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECUVACY#issuecomment-547966987>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGUVECRAPKRIQNHWUHOIQ3QRGSPZANCNFSM4JBI7TAQ> .

-- Russell A. Poldrack Albert Ray Lang Professor of Psychology Professor (by courtesy) of Computer Science Bldg. 420, Jordan Hall Stanford University Stanford, CA 94305 poldrack@stanford.edu http://www.poldracklab.org/

vsoch · 2019-10-30T20:13:33Z

Also a note for everyone - pypi this year has added two factor auth (and are also working on other security measures) so anyone that has an account that can manage packages, in that someone getting access and fussing around would have dire consequences, please strongly consider using it!

poldrack · 2019-10-30T20:23:36Z

thanks, done!

…

On Wed, Oct 30, 2019 at 1:13 PM Vanessasaurus ***@***.***> wrote: Also a note for everyone - pypi this year has added two factor auth <http://pyfound.blogspot.com/2019/06/pypi-now-supports-two-factor-login-via.html> (and are also working on other security measures) so anyone that has an account that can manage packages, in that someone getting access and fussing around would have dire consequences, please strongly consider using it! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33?email_source=notifications&email_token=AAGUVECY4IOTAWISETCG3C3QRHTG5A5CNFSM4JBI7TA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECVTSYI#issuecomment-548092257>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGUVEFHFZK7LRQPHEZ55QDQRHTG5ANCNFSM4JBI7TAQ> .

-- Russell A. Poldrack Albert Ray Lang Professor of Psychology Professor (by courtesy) of Computer Science Bldg. 420, Jordan Hall Stanford University Stanford, CA 94305 poldrack@stanford.edu http://www.poldracklab.org/

ofgulban · 2019-10-30T20:58:20Z

if @ofgulban is happy to do that then I'm happy to add him
…

Yes I am happy to help @poldrack .

poldrack · 2019-10-30T20:59:36Z

please send me your pypi user name...

…

On Wed, Oct 30, 2019 at 1:58 PM Omer Faruk Gulban ***@***.***> wrote: if @ofgulban <https://github.com/ofgulban> is happy to do that then I'm happy to add him … <#m_7198061341754589811_> Yes I am happy to help @poldrack <https://github.com/poldrack> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33?email_source=notifications&email_token=AAGUVEANJO3DRB6QQ3OYGPLQRHYO3A5CNFSM4JBI7TA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECVXZPQ#issuecomment-548109502>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGUVEBFCD33235IARCT3CLQRHYO3ANCNFSM4JBI7TAQ> .

-- Russell A. Poldrack Albert Ray Lang Professor of Psychology Professor (by courtesy) of Computer Science Bldg. 420, Jordan Hall Stanford University Stanford, CA 94305 poldrack@stanford.edu http://www.poldracklab.org/

effigies · 2019-10-30T21:02:18Z

@ofgulban Gave you write access to the repository. Let me know if you need that bumped to admin.

ofgulban · 2019-10-30T21:02:39Z

my pypi username is ofgulban (https://pypi.org/user/ofgulban/)

ofgulban · 2019-10-30T21:03:41Z

@ofgulban Gave you write access to the repository. Let me know if you need that bumped to admin.

Thanks @effigies . I think it is ok for now. If need it I will let you know.

ofgulban · 2019-10-31T10:38:33Z

@effigies could you bump me to admin? I need it to setup zenodo.

Also, I think it would be safe to limit write access to master branch after releasing 2.0.0 without further change in the code and develop in devel branch in the future. I can also handle this.

effigies · 2019-10-31T15:26:43Z

@ofgulban Done.

ofgulban · 2019-10-31T16:46:40Z

Thanks @effigies zenodo badge is ready.

@poldrack it seems that I do not have the right permissions to upload to pypi. My pypi username is ofgulban (https://pypi.org/user/ofgulban/), in case if you have missed the message above.

poldrack · 2019-10-31T16:49:03Z

ok, you've been added as a maintainer on pypi

…

On Wed, Oct 30, 2019 at 2:02 PM Omer Faruk Gulban ***@***.***> wrote: my pypi username is ofgulban (https://pypi.org/user/ofgulban/) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33?email_source=notifications&email_token=AAGUVEHJDOWEO2CGXEWI5TLQRHY67A5CNFSM4JBI7TA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECVYFXQ#issuecomment-548111070>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGUVEB3CI4ZHZRZFBTXSBTQRHY67ANCNFSM4JBI7TAQ> .

-- Russell A. Poldrack Albert Ray Lang Professor of Psychology Professor (by courtesy) of Computer Science Bldg. 420, Jordan Hall Stanford University Stanford, CA 94305 poldrack@stanford.edu http://www.poldracklab.org/

ofgulban · 2019-10-31T16:55:18Z

@poldrack thanks. Could you also add me as a maintainer in https://test.pypi.org/ . It would be cleaner to check if everything looks alright there.

effigies · 2019-10-31T17:01:33Z

@ofgulban The first uploader becomes maintainer on regular PyPI, so that is likely to be true on the test server. Since pydeface isn't on on there, you should be able to do it yourself.

ofgulban · 2019-10-31T17:04:54Z

Oh I see.

poldrack · 2019-10-31T18:03:02Z

yep, i never added it to test

…

On Thu, Oct 31, 2019 at 10:04 AM Omer Faruk Gulban ***@***.***> wrote: Oh I see. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33?email_source=notifications&email_token=AAGUVECGZ2EHCFVBGC2RXS3QRMF3PA5CNFSM4JBI7TA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECYQZNY#issuecomment-548474039>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGUVEEULZ2LDQTRGKP2K63QRMF3PANCNFSM4JBI7TAQ> .

-- Russell A. Poldrack Albert Ray Lang Professor of Psychology Professor (by courtesy) of Computer Science Bldg. 420, Jordan Hall Stanford University Stanford, CA 94305 poldrack@stanford.edu http://www.poldracklab.org/

ofgulban · 2019-10-31T18:11:00Z

I did some cosmetic changes in readme and setup.py. Did not touch to any code for now.
I have fixed the versioning. It is 2.0.0 now.
Setup zenodo integration. See https://zenodo.org/record/3524401.
Uploaded to pypi (https://pypi.org/project/pydeface/>). Seems to work fine

Thanks @octomike & @vsoch for highlighting these issues. Thanks @poldrack and @effigies for your quick responses.

I will have a look at the remaining issues and pull requests wheneverly, but probably after ISMRM deadline next week unless if there is sth broken.

ofgulban closed this as completed Nov 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Versioning and pypi upload ? #33

Versioning and pypi upload ? #33

octomike commented Oct 16, 2019

vsoch commented Oct 16, 2019

ofgulban commented Oct 30, 2019 •

edited

Loading

vsoch commented Oct 30, 2019

effigies commented Oct 30, 2019

poldrack commented Oct 30, 2019 via email

vsoch commented Oct 30, 2019

poldrack commented Oct 30, 2019 via email

ofgulban commented Oct 30, 2019

poldrack commented Oct 30, 2019 via email

effigies commented Oct 30, 2019

ofgulban commented Oct 30, 2019

ofgulban commented Oct 30, 2019

ofgulban commented Oct 31, 2019

effigies commented Oct 31, 2019

ofgulban commented Oct 31, 2019

poldrack commented Oct 31, 2019 via email

ofgulban commented Oct 31, 2019

effigies commented Oct 31, 2019 •

edited

Loading

ofgulban commented Oct 31, 2019

poldrack commented Oct 31, 2019 via email

ofgulban commented Oct 31, 2019

Versioning and pypi upload ? #33

Versioning and pypi upload ? #33

Comments

octomike commented Oct 16, 2019

vsoch commented Oct 16, 2019

ofgulban commented Oct 30, 2019 • edited Loading

vsoch commented Oct 30, 2019

effigies commented Oct 30, 2019

poldrack commented Oct 30, 2019 via email

vsoch commented Oct 30, 2019

poldrack commented Oct 30, 2019 via email

ofgulban commented Oct 30, 2019

poldrack commented Oct 30, 2019 via email

effigies commented Oct 30, 2019

ofgulban commented Oct 30, 2019

ofgulban commented Oct 30, 2019

ofgulban commented Oct 31, 2019

effigies commented Oct 31, 2019

ofgulban commented Oct 31, 2019

poldrack commented Oct 31, 2019 via email

ofgulban commented Oct 31, 2019

effigies commented Oct 31, 2019 • edited Loading

ofgulban commented Oct 31, 2019

poldrack commented Oct 31, 2019 via email

ofgulban commented Oct 31, 2019

ofgulban commented Oct 30, 2019 •

edited

Loading

effigies commented Oct 31, 2019 •

edited

Loading