Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort error messages by line number #12

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 3 comments
Closed

Sort error messages by line number #12

GoogleCodeExporter opened this issue Mar 14, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Currently error messages are reported in the order they appear in byte code. 
Unfortunaetly with synthetic methods like used for closures or access$X stuff, 
the methods may come later in byte code, so those synthetics are listed after 
other failures, although line number is lower.

The fix would be to buffer the error messages and sort them by line number 
before output. This would also allow to make them accessible in a more 
structured way from code.

Original issue reported on code.google.com by uwe.h.schindler on 27 Sep 2013 at 9:24

@GoogleCodeExporter
Copy link
Author

Original comment by uwe.h.schindler on 27 Sep 2013 at 9:24

  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

This issue is a prerequisite for issue #34. Issue #34 will just add final 
buffered output and sorting if the suppressing annotation is not visible.

Original comment by uwe.h.schindler on 25 Dec 2014 at 12:33

@GoogleCodeExporter
Copy link
Author

Committed in r346:
Capture synthetic "lambda$" methods and keep them in the declaring method while 
outputting forbidden violations: Introduce groupId for each code block, map 
groupId of lambdas back to their declaring method (where the corresponding INDY 
was seen)

Before this commit there were more refactorings in the checker code to have 
more classes. Also the forbidden violations were buffered (but not yet sorted), 
before they were printed.

Original comment by uwe.h.schindler on 26 Dec 2014 at 12:38

  • Changed state: Committed

uschindler added a commit that referenced this issue Mar 14, 2015
…eclaring method while outputting forbidden violations: Introduce groupId for each code block, map groupId of lambdas back to their declaring method (where the corresponding INDY was seen)
uschindler added a commit that referenced this issue Mar 14, 2015
… INDY calls, not when used with other constant references (LDC)
@uschindler uschindler added this to the 1.8 milestone Mar 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants