Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some initialization steps (especially reflection) to Plugin's static initialization #166

Merged
merged 1 commit into from
May 7, 2020

Conversation

uschindler
Copy link
Member

This PR is trying to remove more stuff from the apply phase of plugin (which applies per project) to the JVM initialization (when forbiddenapis is loaded). So the runtime cost for each project is hopefully reduced. This includes:

  • reflection of the extension properties (this is just creating a list of property names used to populate conventionmapping) when the task is actually created. Previously this was done on apply of plugin to project.
  • initialization of task avoidance flag

See elastic/elasticsearch#56330

@uschindler uschindler merged commit bcd08c0 into master May 7, 2020
@uschindler uschindler deleted the dev/plugin-init-statics branch May 7, 2020 23:39
@uschindler uschindler self-assigned this Sep 23, 2020
@uschindler uschindler added this to the 3.1 milestone Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant