Update to Java 6 as minimum requirement #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tible with Java 6 - TODO fix this)
…clude ASM into classpath, but made for ASM5)
|
Great, +1! |
|
There was a small issue with JARJAR: On Maven was only version 1.3, but this had a bug with Java 6 class files (https://code.google.com/p/jarjar/issues/detail?id=20), fixed in 1.4. But this one was missing in Maven Central. I use the class files from Maven's JARJAR plugin, which also works with Java 8+. This is a fork and maintained. I only need to add ASM 5 to classpath for build tools. |
uschindler
added a commit
that referenced
this pull request
Sep 9, 2015
Update to Java 6 as minimum requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to updating the Gradle Plugin for Gradle 2.x we should rely on minimum Java 6. Java 5 is now really dead.