268 bug the title 2 total values and hence the overall total values returned by the all programs endpoint needs to be corrected #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P sub program. This changes the Title-2 total benefit amount value and the overall total benefit amount value.
|
Previously, each state had an entry "18-22 All Programs Total" that is no longer there, it only exists in the "total" entry, is that expected? |
navarroc
reviewed
Nov 2, 2024
Good catch. It was unintentional. I only wanted to change the final total calculation to the end. I have added it back. |
navarroc
approved these changes
Nov 4, 2024
|
I'm changing this to a draft PR. I will make it ready for review very soon. I think the updated SQL query needs a fix. Sorry for the inconvenience. |
|
The latest version from this PR (#269) is deployed to the development instance. I have verified that the sum of individual title amounts and sum of individual year amounts matches the overall total. Please review this soon, and we can proceed with the release soon after. Thanks. |
|
Looks good to me and matches what I see locally. Good work! |
ylyangtw
approved these changes
Nov 4, 2024
|
Thanks for the reviews. I will merge this PR now. |
sandeep-ps
deleted the
268-bug-the-title-2-total-values-and-hence-the-overall-total-values-returned-by-the-all-programs-endpoint-needs-to-be-corrected
branch
sandeep-ps
added a commit
that referenced
this pull request
Nov 14, 2024
* Release 0.19.0 * 268 bug the title 2 total values and hence the overall total values returned by the all programs endpoint needs to be corrected (#269) * When calculating total benefit payment, in CRP, include only Total CRP sub program. This changes the Title-2 total benefit amount value and the overall total benefit amount value. * Update CHANGELOG. * Update README with detail on total payment amount calculation. * Add total for year range to state JSON object. * Use start and end years to calculate key and minor changes to comments. * Fix SQL query for total payment calculation by including Title-1 sub programs. * Simplify the SQL queries. --------- Co-authored-by: YONG WOOK KIM <ywkim312@users.noreply.github.com>
sandeep-ps
added a commit
that referenced
this pull request
Nov 26, 2024
* 268 bug the title 2 total values and hence the overall total values returned by the all programs endpoint needs to be corrected (#269) * When calculating total benefit payment, in CRP, include only Total CRP sub program. This changes the Title-2 total benefit amount value and the overall total benefit amount value. * Update CHANGELOG. * Update README with detail on total payment amount calculation. * Add total for year range to state JSON object. * Use start and end years to calculate key and minor changes to comments. * Fix SQL query for total payment calculation by including Title-1 sub programs. * Simplify the SQL queries. * Prep for release 0.20.0 (#282) * Update CHANGELOG. * Update version numbers. --------- Co-authored-by: YONG WOOK KIM <ywkim312@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.