Allow FireFox to play at readystate 2, but protect other browsers #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull prevents a premature play() request on video elements at readystate 2, except for Firefox that is ready to play at ready state 2.
Safari drops from readystate 3 to readystate 2 when it is buffering and cannot play a video. Requesting play() on Safari at readystate 2 causes the video to stall.
Chrome is not impacted by this pull because it moves quickly from readystate 2 to 3 during load. This also appears to be the case for other browsers.
Our site has been using this patch for many months with a diverse (in regards to devices and OS) and remote student body.