Merge pull request #210 from politie/fix-other-react-signature

fix other $react signature
politie · Jun 22, 2021 · caf353c · caf353c
2 parents 1e1f0bc + c316b90
commit caf353c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8,456 deletions.
diff --git a/extensions/sherlock-proxy/proxy.ts b/extensions/sherlock-proxy/proxy.ts
@@ -36,7 +36,7 @@ export interface DerivableProxy<V> {
     $derive<R, P>(f: (v: V, ...ps: P[]) => R, ...ps: Array<MaybePacked<P>>): Derivable<R>;
 
     /** {@see Derivable#react} */
-    $react(reaction: (value: V) => void, options?: Partial<ReactorOptions<V>>): () => void;
+    $react(reaction: (value: V, stop: () => void) => void, options?: Partial<ReactorOptions<V>>): () => void;
 }
 
 const IS_DERIVABLE_PROXY = Symbol('isDerivableProxy');