Type checking for g_variant_get calls #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids trying to read things as "(u)" when they're "(s)" for example.
|
I like the changes. I have been waiting on poliva to release a new version for the past 6 months. I hope he will be able to see the PR and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the calls to
g_variant_get()just assume that the format string works, but don't check that this is in fact the case.On my system, the results are all string types (since there's an error), but the code was continuing as if nothing happened. With this change, it correctly falls back to using the xbacklight backend.
(This also has inconsequential whitespace changes; I can re-make the PR without those if you want. They are a separate commit.)