-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client does not exit after invoking .destroy() #327
Comments
Bullrich
added a commit
to paritytech/get-fellows-action
that referenced
this issue
Mar 14, 2024
It was reported in polkadot-api/polkadot-api#327 that PAPI does not exit correctly. Until this is fixed, we need to add this parameter
Bullrich
added a commit
to paritytech/get-fellows-action
that referenced
this issue
Mar 15, 2024
Until polkadot-api/polkadot-api#327 is fixed, we need to manually exit the process
Bullrich
added a commit
to paritytech/get-fellows-action
that referenced
this issue
Mar 15, 2024
Migrated from `@polkadot/api` to `@polkadot-api/api` after watching @josepot's video. All the code entry points are still the same. So are the tests. This resolves #9 Thanks you @josepot and @kratico for your help implementing PAPI and smoldot. This commit also has a dirty fix to the issue reported in polkadot-api/polkadot-api#327
Merged
Bullrich
added a commit
to paritytech/get-fellows-action
that referenced
this issue
Jul 2, 2024
Upgraded yarn to version 4 Upgraded all the dependencies to latest. - papi `0.4.0` -> `0.9.0` which contains a fix for polkadot-api/polkadot-api#327
Bullrich
added a commit
to Bullrich/polkadot-fellows-runtimes
that referenced
this issue
Jul 3, 2024
This commit updates get-fellows-action to v1.1.4 where `papi` was updated to latest (`0.9.0`) which contains a fix for polkadot-api/polkadot-api#327. This will accelerate the process of the triggering of review-bot. Review-bot has also been updated to latest. It has the pull request number being injected, so it will always fetch the latest status when it runs.
1 task
Bullrich
added a commit
to Bullrich/polkadot-fellows-runtimes
that referenced
this issue
Jul 3, 2024
This commit updates get-fellows-action to v1.1.4 where `papi` was updated to latest (`0.9.0`) which contains a fix for polkadot-api/polkadot-api#327. This will accelerate the process of the triggering of review-bot. Review-bot has also been updated to latest. It has the pull request number being injected, so it will always fetch the latest status when it runs.
fellowship-merge-bot bot
added a commit
to polkadot-fellows/runtimes
that referenced
this issue
Jul 3, 2024
This commit updates get-fellows-action to v1.1.4 where `papi` was updated to latest (`0.9.0`) which contains a fix for polkadot-api/polkadot-api#327. This will accelerate the process of the triggering of review-bot. Review-bot has also been updated to latest. It has the pull request number being injected, so it will always fetch the latest status when it runs. With the fix provided in #369 this should make the whole process work as intended. - [x] Does not require a CHANGELOG entry --------- Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running tests the client does not properly exit, keeping the thread running.
This happens even when
.destroy()
is invoked.This gives problems with test suites, as they never finish.
It is currently making paritytech/get-fellows-action#11 test fail by timing out.
Minimal reproduction
Test file in src/test/papi.test.ts
Log result
The text was updated successfully, but these errors were encountered: