Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validator to dispatch precompile #1042

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

boundless-forest
Copy link
Collaborator

I do not fully understand why we check the Pays and DispatchClass before dispatching. I guess it's to prevent spam payless dispatch, there seems no need to do that, some basic transaction fee was charged when you invoke the dispatch precompile transaction. But this block dispatch the Operational type call.

In addition, add a filter to before dispatch to support filtering some call according to different runtimes.

@boundless-forest boundless-forest changed the title Add filter to dispatch precompile Add validator to dispatch precompile Apr 19, 2023
@sorpaas sorpaas merged commit 8b10017 into polkadot-evm:master Apr 19, 2023
@boundless-forest boundless-forest deleted the bear-update-dispatch branch April 20, 2023 00:13
ashutoshvarma pushed a commit to AstarNetwork/frontier that referenced this pull request May 29, 2023
* Add dispatch filter

* Fix clippy

* Fix review
ashutoshvarma pushed a commit to AstarNetwork/frontier that referenced this pull request Jun 8, 2023
* Add dispatch filter

* Fix clippy

* Fix review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants