Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update polkadot-sdk dependencies to v1.7.0 #1299

Closed
wants to merge 1 commit into from

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Feb 9, 2024

No description provided.

@RomarQ RomarQ marked this pull request as ready for review February 9, 2024 17:34
@RomarQ RomarQ requested a review from sorpaas as a code owner February 9, 2024 17:34
@RomarQ
Copy link
Contributor Author

RomarQ commented Feb 13, 2024

Hi @sorpaas,

Could you have a look at this PR? The dependencies upgrade does not seem to have breaking changes affecting frontier, but let me know if I need to change something. Thank you in advance.

@koushiro
Copy link
Collaborator

koushiro commented Feb 13, 2024

@RomarQ you didn't update the polkadot-sdk correctly, you could check the diff of Cargo.lock, the commit is the same

-source = "git+https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.6.0#925af80de25e26d25bf1b9c3b3746c0b921289a7"
+source = "git+https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.7.0#925af80de25e26d25bf1b9c3b3746c0b921289a7"

@RomarQ
Copy link
Contributor Author

RomarQ commented Feb 13, 2024

@RomarQ you didn't update the polkadot-sdk correctly, you could check the diff of Cargo.lock, the commit is the same

-source = "git+https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.6.0#925af80de25e26d25bf1b9c3b3746c0b921289a7"
+source = "git+https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.7.0#925af80de25e26d25bf1b9c3b3746c0b921289a7"

You are right @koushiro, will close this PR since we now have #1300

@RomarQ RomarQ closed this Feb 13, 2024
@RomarQ RomarQ deleted the polkadot-v1.7.0 branch February 15, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants