Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ethereum extrinsic size is accounted twice for proof size #1568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pLabarta
Copy link
Contributor

Ethereum extrinsic size is accounted twice for proof size, this PR substracts that cost once.

@pLabarta pLabarta marked this pull request as ready for review December 20, 2024 13:14
@pLabarta pLabarta requested a review from sorpaas as a code owner December 20, 2024 13:14
@conr2d
Copy link
Contributor

conr2d commented Dec 25, 2024

IIUC, the Ethereum extrinsic size is accounted for twice:

  • Additional Gas is applied based on the Ethereum transaction size, which is then converted through GasWeightMapping.
  • The size is also accounted for in SelfContainedCall's CheckWeight.

Is my understanding correct? Since SelfContainedCall isn’t designed to be used exclusively with pallet-ethereum, unconditionally subtracting it from actual_weight could result in unexpected behavior. Should we consider adding conditions or refining the logic here?

@boundless-forest
Copy link
Collaborator

#1490 (comment) Check this for some deep thought behind this change. I need more time to figure out if this is the best solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants