-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bot: Notify people about new fellowship referendas #57
Comments
we have similar telegram bots for public referendas - @subvt_kusama_bot and @subvt_polkadot_bot |
I'm personally against telegram :P But maybe if we have a bot that can work for telegram/matrix, I will not complain. Where can this bot be found? |
I would say matrix even have a higher priority since all our communication rooms set there now |
Here's an initial draft of a matrix bot for referenda announcements, implemented on nodejs https://github.com/pandres95/fellowship-referenda-bot Update: Just pushed a couple of commits to update the look of it, making it also readable on mobile devices |
I believe that @rzadp has a bot that already interacts with voting and RFCs. I'll get in contact with him as maybe he can easily adapt it. |
This is not restricted to RFC referendas, can we move this to https://github.com/polkadot-fellows/help-center ? |
As we don't want to have a general referenda bot (which probably already exist), I think it is fine to keep the discussion here. We want to improve the communication around the RFC proposals. |
From what I've done so far with the Matrix box, here's what I consider are the next steps:
Nice to have / Next version:
cc/ @bkchr Update: changed deployment on serverless platform for |
We could probably put it into an action in this repo? |
Updates:
I think is safe to say we can discuss deployment. Wdyt @bkchr? |
Indeed - There are even email/telegram notifications about fellowship referenda right in Subsquare (no matrix support though): So I understand that in this issue we want to focus on RFC referenda specifically. @pandres95 I see you're on top of the matrix bot, but I don't see integration with github in your plan. We already have a github action in this repo that understands RFC PRs and is able to match them with corresponding ongoing referenda. I can work on extending this action with the functionality of posting updates in the PRs and pinging people - this could work in parallel to the matrix bot. |
The GitHub part is not that hard. We can always connect through GitHub Actions, triggered by PR comments and make the association between commenters and the actual referendum, and since both the github profiles and matrix users are tied to each member's identities (or at least, they should be, i.e. I haven't setup my GitHub profile into my identity yet), there's a chance of doing so. The only question is: should those pings be via DMs, or via a threaded reply under the notifications room. But yeah, this can be in parallel. The first part of scheduling notifications to everyone can always be a first release, an MVP of how that'd work in the future. |
What you need to know? |
ping people in DM? did you mean mention their GH handle or in matrix 1:1 ? If someone has an RFC PR open the conversations are already happening there, right? So if someone has commented on PR - they get notification (either push or email) and react, so they What's missing for sure - is referenda status changes in scope of Open RFC PR - whether it's Submitted or Confirmed [rejected/approved], which could also potentially be tracked per PR via GitHub notifications. Then on status change - we could add comment IN the PR. Re. sending to matrix channel - it could also be addition to comment in RFC PR, but what would be a goal?
|
Basically, whether it would be possible to set the bot using username/password, or an access token is preferred. Meanwhile, I'm working on building the GitHub Action to deploy the bot. Aside from that, would be good to know who's the person on the matrix homeserver's end, so they would be able to do the following:
|
Matrix is a decentralized messaging solution. This means that anyone can create a channel (including you). This requires no special permissions. |
Oh, I know that 😅 I was just wondering if there's anyone who can make it "official". But I guess that option of releasing the bot and channel by my own, and then using an invite link for everyone to join is possible, too. I'll do that, then. Releasing tomorrow afternoon for the first announcement next Friday. 🚀 |
Added functionality for a cron job to iterate over all ongoing referendas and compare them to the open PRs. If there is any match on the remark, and the referenda has been opened **after** the last time the action was run, it will comment a link to the referenda in Polkassembly. This is intended to resolve the requirements in polkadot-fellows/RFCs#57
Added RFC Cron job which will iterate over existing referendas and post a link to them in the open Pull Requests. This resolves polkadot-fellows#57 Every time it iterates, it looks for referendas that have been submitted _after_ the time of the last run, to stop itself from posting duplicated comments. It is set to run every day at 12, and it can also be triggered manually.
Added RFC Cron job which will iterate over existing referendas and post a link to them in the open Pull Requests. This resolves #57 Every time it iterates, it looks for referendas that have been submitted _after_ the time of the last run, to stop itself from posting duplicated comments. It is set to run every day at 12, and it can also be triggered manually.
Additionally to #68 @Bullrich have added an auto-message on after confirmation RFC proposal with a command which is easy to copy & paste Going forward, if it works as intended, we could let it auto-merge / close the PR accordingly to a result of a proposal, if that makes sense. For now it's still manual action to process Thanks @Bullrich! |
We should have some bot that is notifying people about new fellowship referendas. The idea was that this bot is maybe posting to the fellowship channel or to some dedicated notifications channel. In a future version it would be also nice to ping people directly when a RFC they commented is put on for voting.
CC @Bullrich @mordamax
The text was updated successfully, but these errors were encountered: