[XCM]: Remove NetworkIds for testnets #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscoaguirre
changed the title
bkchr
approved these changes
Jul 24, 2024
acatangiu
approved these changes
Jul 24, 2024
seadanda
approved these changes
Jul 24, 2024
|
/rfc propose |
|
Hey @franciscoaguirre, here is a link you can use to create the referendum aiming to approve this RFC number 0108. Instructions
It is based on commit hash a17058abc15e9f21423ad03148a0e16fe6aa4490. The proposed remark text is: |
|
Voting for this referenda is ongoing. Vote for it here |
|
PR can be merged. Write the following command to trigger the bot
|
|
/rfc process 0x5e8b9c1d860223df9c30452fe7006cbc928147174130a5cb32355c24adb53d34 |
|
The on-chain referendum has approved the RFC. |
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Aug 14, 2024
In the move from XCMv3 to XCMv4, the `AssetId` for `ForeignAssets` in `asset-hub-rococo` and `asset-hub-westend` was left as `v3::Location` to be later migrated to `v4::Location`. This is that migration PR. Because the encoding of `v3::Location` and `v4::Location` is the same, we don't need to do any data migration, the keys will still be decodable. The [original idea by Jan](paritytech/polkadot#7236) was to make the v4 changes in v3 since the ABI (the encoding/decoding) didn't change. Corroborated the ABI is the same iterating over all storage, the code is on [another branch](https://github.com/paritytech/polkadot-sdk/blob/cisco-assert-v3-v4-encodings-equal/cumulus/parachains/runtimes/assets/migrations/src/foreign_assets_to_v4/mod.rs). We will need a data migration when we want to update from `v4::Location` to `v5::Location` because of [the accepted RFC changing the NetworkId enum](polkadot-fellows/RFCs#108). I'll configure MBMs (Multi-Block Migrations) then and make the actual migration. Fixes #4128 --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <>
franciscoaguirre
added a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Nov 1, 2024
# Context Close #5241, for more detail, please refer to [RFC0108](polkadot-fellows/RFCs#108) # Changes - Remove `Rococo` and `Westend` from `NetworkId` * Add `Rococo Genesis Hash` and `Westend Genesis Hash` --------- Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testnets are not stable and shouldn't be included in the XCM language. They should be able to be specified with
NetworkId::ByGenesis.