Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI for Polkadot People Chain #394

Open
joepetrowski opened this issue Jul 20, 2024 · 2 comments · Fixed by paritytech/get-fellows-action#30 or paritytech/review-bot#131
Open

Comments

@joepetrowski
Copy link
Contributor

joepetrowski commented Jul 20, 2024

The People Chain is now live (here's one endpoint). Therefore, CI should start fetching GitHub handles from the People Chain.

Note that GitHub handles are now first-class fields of the Identity and that Identities with { "github" : "mygithubname" } have been migrated to the new data structure. As in, for example:

[
  {
    judgements: [
      [
        0
        Reasonable
      ]
    ]
    deposit: 203,240,000,000
    info: {
      additional: [
        [
          {
            Raw: github
          }
          {
            Raw: joepetrowski
          }
        ]
      ]
      display: {
        Raw: Joe
      }
      legal: {
        Raw: Joe Petrowski
      }
      web: None
      riot: None
      email: {
        Raw: joe@petrow.ski
      }
      pgpFingerprint: null
      image: None
      twitter: None
    }
  }
  null
]

Becomes:

[
  {
    judgements: [
      [
        0
        Reasonable
      ]
    ]
    deposit: 0
    info: {
      display: {
        Raw: Joe
      }
      legal: {
        Raw: Joe Petrowski
      }
      web: None
      matrix: None
      email: {
        Raw: joe@petrow.ski
      }
      pgpFingerprint: null
      image: None
      twitter: None
      github: {
        Raw: joepetrowski
      }
      discord: None
    }
  }
  null
]

(Also note that riot has changed to matrix.)

The switch should happen prior to 25 July, when ref 983 enacts. At this point, identities can start being removed from the Relay Chain, so it will no longer be a reliable source of the information.

CC @pepoviola @mordamax

@pepoviola
Copy link
Contributor

Cc @Bullrich

@josepot
Copy link

josepot commented Jul 23, 2024

The People Chain is now live (here's one endpoint). Therefore, CI should start fetching GitHub handles from the People Chain.

FWIW the chain-spec of the Polkadot People Chain is nowhere to be found.

mutantcornholio added a commit to paritytech/get-fellows-action that referenced this issue Jul 29, 2024
- Migrated the chain from polkadot to `People Chain`.
  - Resolves #29 and resolves polkadot-fellows/runtimes#394
- Updated PAPI to latest (it now has a `.papi` directory).
  - Removed slim node docker image and bundled everything together
- Polkadot-API depends on some dependencies that `ncc` is not bundling
together so we need to keep the `node_modules` (like
`@polkadot-api/metadata-compatibility`)
 - Updated to version `1.2.0`

---------

Co-authored-by: cornholio <0@mcornholio.ru>
mutantcornholio added a commit to paritytech/review-bot that referenced this issue Jul 29, 2024
- Migrated the chain from polkadot to `People Chain`.
  - Resolves #130 and resolves polkadot-fellows/runtimes#394
- Upgraded project to use PAPI (it now has a `.papi` directory).
  - Removed slim node docker image and bundled everything together
- Polkadot-API depends on some dependencies that `ncc` is not bundling
together so we need to keep the `node_modules` (like
`@polkadot-api/metadata-compatibility`)
 - Updated to version `2.6.0`

---------

Co-authored-by: cornholio <0@mcornholio.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants