Added Polkadot <> Kusama bridge configuration #108

svyatonik · 2023-11-30T14:14:17Z

This PR adds bridge configuration to allow exchanging assets between Polkadot and Kusama Asset Hubs. So far we only support sending KSM from Kusama Asset Hub to Polkadot Asset Hub as wKSM + DOT from Polkadot Asset Hub to Kusama Asset Hub as wDOT. Other assets may be added later.

The opposite direction is also supported, though it'll need dependencies upgrade to >= v1.4.

Similar Rococo <> Westend bridge is also active on live chains. You may read docs on how to play with it here: https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/parachains/runtimes/bridge-hubs/README.md

For Polkadot <> Kusama bridge we have a dedicated branch for local zombienet tests: https://github.com/svyatonik/runtimes/tree/sv-pk-bridge-with-zombienet-tests. You may run autotests (exchanging assets) there - see https://github.com/svyatonik/runtimes/blob/sv-pk-bridge-with-zombienet-tests/system-parachains/bridge-hubs/zombienet/README.md for details. You may do manual tests by spawning local chains using those scripts and use https://github.com/svyatonik/runtimes/blob/sv-pk-bridge-with-zombienet-tests/system-parachains/bridge-hubs/zombienet/scripts/bridges_kusama_polkadot.sh script to run various commands - i.e. send assets manually. Polkadot js apps is also supported.

…d once we have weights + tests

…00_000_000. Otherwise msg is treated as overweight by target AH and is not autodispatched. Need to check that before release

…k pallet --chain bh-polkadot-local-raw.json --pallet pallet-bridge-grandpa --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights --no-median-slopes --no-min-squares

…k pallet --chain bh-polkadot-local-raw.json --pallet pallet-bridge-relayers --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights --no-median-slopes --no-min-squares

…k pallet --chain bh-polkadot-local-raw.json --pallet pallet-bridge-parachains --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights --no-median-slopes --no-min-squares

…k pallet --chain bh-polkadot-local-raw.json --pallet pallet-bridge-messages --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights --no-median-slopes --no-min-squares

…k pallet --chain bh-polkadot-local-raw.json --pallet pallet-xcm-benchmarks:: --extrinsic "report_holding,buy_execution,query_response,transact,refund_surplus,set_error_handler,set_appendix,clear_error,descend_origin,clear_origin,report_error,claim_asset,trap,subscribe_version,unsubscribe_version,burn_asset,expect_asset,expect_origin,expect_error,expect_transact_status,query_pallet,report_transact_status,clear_transact_status,set_topic,clear_topic,export_message,set_fees_mode,unpaid_execution" --output=system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights/xcm --no-median-slopes --no-min-squares + manually add expect_pallet benchmark results

…k pallet --chain bh-polkadot-local-raw.json --pallet pallet-xcm-benchmarks::fungible --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights/xcm --no-median-slopes --no-min-squares

…k pallet --chain bh-kusama-local-raw.json --pallet pallet-bridge-grandpa --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-kusama/src/weights --no-median-slopes --no-min-squares

…k pallet --chain bh-kusama-local-raw.json --pallet pallet-bridge-relayers --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-kusama/src/weights --no-median-slopes --no-min-squares

…k pallet --chain bh-kusama-local-raw.json --pallet pallet-bridge-parachains --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-kusama/src/weights --no-median-slopes --no-min-squares

…k pallet --chain bh-kusama-local-raw.json --pallet pallet-bridge-messages --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-kusama/src/weights --no-median-slopes --no-min-squares

…k pallet --chain bh-kusama-local-raw.json --pallet pallet-xcm-benchmarks::generic --extrinsic "report_holding,buy_execution,query_response,transact,refund_surplus,set_error_handler,set_appendix,clear_error,descend_origin,clear_origin,report_error,claim_asset,trap,subscribe_version,unsubscribe_version,burn_asset,expect_asset,expect_origin,expect_error,expect_transact_status,query_pallet,report_transact_status,clear_transact_status,set_topic,clear_topic,export_message,set_fees_mode,unpaid_execution" --output=system-parachains/bridge-hubs/bridge-hub-kusama/src/weights/xcm --no-median-slopes --no-min-squares

…k pallet --chain bh-kusama-local-raw.json --pallet pallet-xcm-benchmarks::fungible --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-kusama/src/weights/xcm --no-median-slopes --no-min-squares

…k pallet --chain ah-polkadot-local-raw.json --pallet pallet-xcm-benchmarks::generic --extrinsic "report_holding,buy_execution,query_response,transact,refund_surplus,set_error_handler,set_appendix,clear_error,descend_origin,clear_origin,report_error,claim_asset,trap,subscribe_version,unsubscribe_version,burn_asset,expect_asset,expect_origin,expect_error,expect_transact_status,query_pallet,report_transact_status,clear_transact_status,set_topic,clear_topic,export_message,set_fees_mode,unpaid_execution" --output=system-parachains/asset-hubs/asset-hub-polkadot/src/weights/xcm --no-median-slopes --no-min-squares

…k pallet --chain ah-polkadot-local-raw.json --pallet pallet-xcm-benchmarks::fungible --extrinsic "*" --output=system-parachains/asset-hubs/asset-hub-polkadot/src/weights/xcm --no-median-slopes --no-min-squares

acatangiu · 2023-12-13T10:44:22Z

@KiChjang @muharem please help with reviews of this PR which is mostly XCM and System Chains changes.

muharem · 2023-12-15T11:43:50Z

system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs

@@ -258,6 +262,17 @@ impl Contains<RuntimeCall> for SafeCallFilter {
 			}
 		}

+		// Allow to change dedicated storage items (called by governance-like)
+		match call {
+			RuntimeCall::System(frame_system::Call::set_storage { items })


this does breaks the third rule described above in the docs for SafeCallFilter. However, it's worth checking whether those rules can be removed, if these changes included in the current release - paritytech/polkadot-sdk#1246

Only reads affect proof size and set_storage makes no any reads. Also we use .iter().all(), comparing with just two keys, so it won't make more than two writes, so this vec is kinda bounded.

muharem · 2023-12-15T12:19:46Z

system-parachains/bridge-hubs/bridge-hub-kusama/primitives/src/lib.rs

+pub const WITH_BRIDGE_HUB_KUSAMA_RELAYERS_PALLET_NAME: &str = "BridgeRelayers";
+
+/// Pallet index of `BridgePolkadotMessages: pallet_bridge_messages::<Instance1>`.
+pub const WITH_BRIDGE_KUSAMA_TO_POLKADOT_MESSAGES_PALLET_INDEX: u8 = 53;


these look like constants, not primitives. wont block PR because of this

It declares some primitives as well - e.g. it reexports hashers, block numbers and etc. So it is both consts and primitives.

bkchr

Left some comments. Clearly did not read every detail of the pr, but looking good from what I can say.

system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs

system-parachains/bridge-hubs/bridge-hub-kusama/primitives/src/lib.rs

bkchr · 2024-01-05T21:09:34Z

system-parachains/bridge-hubs/bridge-hub-polkadot/primitives/src/lib.rs

+	pub const BridgeHubPolkadotBaseDeliveryFeeInDots: Balance = 16_954_899_613;
+
+	/// Transaction fee that is paid at the Polkadot BridgeHub for delivering single outbound message confirmation.
+	/// (initially was calculated by test `BridgeHubPolkadot::can_calculate_fee_for_complex_message_confirmation_transaction` + `33%`)
+	pub const BridgeHubPolkadotBaseConfirmationFeeInDots: Balance = 16_183_099_613;


1.6DOT? is that correct?

@bkontur any idea about this?

Yes this is the current cost

bkchr · 2024-01-05T21:10:53Z

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_kusama_config.rs

+	/// Number of Kusama Bridge Hub headers to keep in the runtime storage.
+	///
+	/// Note that we are keeping only required header information, not the whole header itself. Roughly, it
+	/// is the 2 hours of real time (assuming that every header is submitted).


But 1 hour are 600 blocks, so shouldn't this be 1200 for keeping 2 hours?

Ahh, RelayChainHeadersToKeep is correct. I assume this still assumes that there are only a parachain block every 12 seconds? If yes, this is not correct anymore and we should update this as well to 1200.

bkchr · 2024-01-05T21:12:44Z

system-parachains/bridge-hubs/bridge-hub-kusama/src/bridge_to_polkadot_config.rs

+	///
+	/// Note that we are keeping only required header information, not the whole header itself. Roughly, it
+	/// is the 2 hours of real time (assuming that every header is submitted).
+	pub const ParachainHeadsToKeep: u32 = 600;


Same comment as for Polkadot.

bkchr · 2024-01-08T11:09:40Z

@svyatonik @acatangiu can you please merge master and fix the merge conflicts?

bkontur · 2024-01-08T11:32:02Z

@svyatonik @acatangiu can you please merge master and fix the merge conflicts?

I think both are ooo, I will try

bkchr · 2024-01-08T11:34:28Z

Ty!

# Conflicts: # relay/kusama/src/weights/pallet_xcm_benchmarks_generic.rs # system-parachains/asset-hubs/asset-hub-kusama/src/weights/pallet_xcm_benchmarks_fungible.rs # system-parachains/asset-hubs/asset-hub-kusama/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/weights/pallet_xcm_benchmarks_fungible.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs # system-parachains/bridge-hubs/bridge-hub-kusama/src/weights/pallet_xcm_benchmarks_fungible.rs # system-parachains/bridge-hubs/bridge-hub-kusama/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs # system-parachains/bridge-hubs/bridge-hub-kusama/tests/tests.rs # system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights/pallet_xcm_benchmarks_fungible.rs # system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs # system-parachains/bridge-hubs/bridge-hub-polkadot/tests/tests.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

…/lib.rs Co-authored-by: Bastian Köcher <git@kchr.de>

bkchr · 2024-01-08T16:21:25Z

/merge

fellowship-merge-bot · 2024-01-08T16:22:04Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

@vgeddes

- [x] Adds asset hub and bridge hub to Kusama and Polkadot runtimes - [x] based off #108 - needs to be merged first - [x] snowbridge crates needs to be published on crates.io - depends on `polkadot-sdk 1.7.0` - [x] MessageQueue Pallet is not configured on Kusama and Polkadot asset hub - added in #137 - [x] `FeeManager` `handle_fee` misses reason, crate needs to be updated I think cc @vgeddes @alistair-singh @yrong @musnit --------- Signed-off-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Ross Bulat <ross@parity.io> Co-authored-by: claravanstaden <Cats 4 life!> Co-authored-by: Alain Brenzikofer <alain@integritee.network> Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: brenzi <brenzi@users.noreply.github.com> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: ron <yrong1997@gmail.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: Vincent Geddes <vincent.geddes@hey.com>

svyatonik and others added 30 commits November 30, 2023 08:45

add bridging stuff to Kusama Bridge Hub

014dbe9

add bridging stuff to Polkadot Bridge Hub

7a5d3ce

add bridging stuff to Kusama Asset Hub

d54a80e

add bridging stuff to Polkadot Asset Hub

82cf606

Allow initialize bridge

601c8b9

Add BridgeHub to the trusted teleporters for relaychain.

7fd0081

Moved in bp-bridge-hub-kusama and bp-bridge-hub-cumulus

51d2501

Bring in bp-bridge-hub-polkadot

9f435e7

Bring in bp-asset-hub-kusama and bp-asset-hub-polkadot

2516bb8

use bp-bridge-hub-cumulus instead of local bridge-hub-common

f48d8de

post-rebase fixes

64a61ce

tune balance - otherwise msg is rejected by source BH. Should be fixe…

335449f

…d once we have weights + tests

change weight of reserve_asset_deposited from 500_000_000_000 to 20_0…

82235f8

…00_000_000. Otherwise msg is treated as overweight by target AH and is not autodispatched. Need to check that before release

moved (un)CongestedMessage to local primitives crates

6bfb2b5

fmt

9735c10

compilation

fee80e4

../polkadot-sdk/target/release/polkadot-parachain-benchmarks benchmar…

adf283f

…k pallet --chain bh-polkadot-local-raw.json --pallet pallet-bridge-grandpa --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights --no-median-slopes --no-min-squares

../polkadot-sdk/target/release/polkadot-parachain-benchmarks benchmar…

50c1807

…k pallet --chain bh-polkadot-local-raw.json --pallet pallet-bridge-relayers --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights --no-median-slopes --no-min-squares

../polkadot-sdk/target/release/polkadot-parachain-benchmarks benchmar…

53079ea

…k pallet --chain bh-polkadot-local-raw.json --pallet pallet-bridge-parachains --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights --no-median-slopes --no-min-squares

../polkadot-sdk/target/release/polkadot-parachain-benchmarks benchmar…

b0cbbc1

…k pallet --chain bh-polkadot-local-raw.json --pallet pallet-bridge-messages --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-polkadot/src/weights --no-median-slopes --no-min-squares

../polkadot-sdk/target/release/polkadot-parachain-benchmarks benchmar…

eec040b

…k pallet --chain bh-kusama-local-raw.json --pallet pallet-bridge-grandpa --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-kusama/src/weights --no-median-slopes --no-min-squares

../polkadot-sdk/target/release/polkadot-parachain-benchmarks benchmar…

016a5f0

…k pallet --chain bh-kusama-local-raw.json --pallet pallet-bridge-relayers --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-kusama/src/weights --no-median-slopes --no-min-squares

../polkadot-sdk/target/release/polkadot-parachain-benchmarks benchmar…

12a03d3

…k pallet --chain bh-kusama-local-raw.json --pallet pallet-bridge-parachains --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-kusama/src/weights --no-median-slopes --no-min-squares

../polkadot-sdk/target/release/polkadot-parachain-benchmarks benchmar…

e92ad1a

…k pallet --chain bh-kusama-local-raw.json --pallet pallet-bridge-messages --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-kusama/src/weights --no-median-slopes --no-min-squares

../polkadot-sdk/target/release/polkadot-parachain-benchmarks benchmar…

6294cb7

…k pallet --chain bh-kusama-local-raw.json --pallet pallet-xcm-benchmarks::fungible --extrinsic "*" --output=system-parachains/bridge-hubs/bridge-hub-kusama/src/weights/xcm --no-median-slopes --no-min-squares

../polkadot-sdk/target/release/polkadot-parachain-benchmarks benchmar…

0e1c7e6

…k pallet --chain ah-polkadot-local-raw.json --pallet pallet-xcm-benchmarks::fungible --extrinsic "*" --output=system-parachains/asset-hubs/asset-hub-polkadot/src/weights/xcm --no-median-slopes --no-min-squares

svyatonik added 4 commits December 13, 2023 09:28

Merge remote-tracking branch 'origin/main' into sv-pk-bridge

e90daad

added bridge mention to changelog

fe18826

fmt

3ea9722

-unused import

a312317

svyatonik added 2 commits December 14, 2023 15:54

allow relay chain governance to halt and resume bridge pallets

7594f02

update bridge fees using last changes in tests + estimations

9542090

muharem reviewed Dec 15, 2023

View reviewed changes

claravanstaden mentioned this pull request Dec 22, 2023

Adds Snowbridge to Kusama and Polkadot Runtimes #130

Merged

5 tasks

svyatonik mentioned this pull request Dec 28, 2023

Question: can this be used to create a bridge to ZCash? paritytech/parity-bridges-common#2762

Closed

acatangiu mentioned this pull request Jan 3, 2024

[asset-hubs/bridge-hubs] Bridging Polkadot Asset Hub <-> Kusama Asset Hub to enable asset transfer of KSMs/DOTs paritytech/polkadot-sdk#1352

Closed

9 tasks

ordian mentioned this pull request Jan 3, 2024

Add basic XCM emulator tests #114

Merged

bkchr approved these changes Jan 5, 2024

View reviewed changes

bkontur mentioned this pull request Jan 8, 2024

Add integration xcm-emulator tests for bridge-hubs to K/P bridging in fellows repo paritytech/parity-bridges-common#2791

Closed

bkontur and others added 6 commits January 8, 2024 15:02

Update system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs

7281a23

Co-authored-by: Bastian Köcher <git@kchr.de>

Update system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

987c181

Co-authored-by: Bastian Köcher <git@kchr.de>

Update system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs

6eb9d42

Co-authored-by: Bastian Köcher <git@kchr.de>

Update system-parachains/bridge-hubs/bridge-hub-kusama/primitives/src…

70f0a20

…/lib.rs Co-authored-by: Bastian Köcher <git@kchr.de>

fmt

ba94fff

fix

b26a5be

fellowship-merge-bot bot merged commit 98872cb into polkadot-fellows:main Jan 8, 2024
15 checks passed

CanonicalJP mentioned this pull request Jan 8, 2024

[polkadot-fellows/runtimes/pull/108] Added Polkadot <> Kusama bridge configuration paritytech/polkadot-sdk#2880

Closed

bkontur mentioned this pull request Feb 7, 2024

Migrate asset transfer over bridge to polkadot-fellows paritytech/parity-bridges-common#2541

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Polkadot <> Kusama bridge configuration #108

Added Polkadot <> Kusama bridge configuration #108

svyatonik commented Nov 30, 2023

acatangiu commented Dec 13, 2023

muharem Dec 15, 2023

svyatonik Dec 15, 2023

muharem Dec 15, 2023

svyatonik Dec 15, 2023

bkchr left a comment

bkchr Jan 5, 2024

bkchr Jan 8, 2024

acatangiu Jan 8, 2024

bkchr Jan 5, 2024

bkchr Jan 5, 2024

bkchr Jan 5, 2024

bkchr commented Jan 8, 2024

bkontur commented Jan 8, 2024

bkchr commented Jan 8, 2024

bkchr commented Jan 8, 2024

fellowship-merge-bot bot commented Jan 8, 2024

Added Polkadot <> Kusama bridge configuration #108

Added Polkadot <> Kusama bridge configuration #108

Conversation

svyatonik commented Nov 30, 2023

acatangiu commented Dec 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bkchr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bkchr commented Jan 8, 2024

bkontur commented Jan 8, 2024

bkchr commented Jan 8, 2024

bkchr commented Jan 8, 2024

fellowship-merge-bot bot commented Jan 8, 2024