-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually Lower ED #158
Merged
fellowship-merge-bot
merged 9 commits into
polkadot-fellows:main
from
joepetrowski:actually-fix-ed
Jan 25, 2024
Merged
Actually Lower ED #158
fellowship-merge-bot
merged 9 commits into
polkadot-fellows:main
from
joepetrowski:actually-fix-ed
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
approved these changes
Jan 24, 2024
ggwpez
approved these changes
Jan 24, 2024
some high level chain specific e2e tests will caught this |
xlc
approved these changes
Jan 24, 2024
Yes I know, that's why it's one of my main priorities the next 6 months. |
acatangiu
approved these changes
Jan 25, 2024
acatangiu
approved these changes
Jan 25, 2024
/merge |
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit Jan 25, 2024
4e41af1
into
polkadot-fellows:main
16 checks passed
ggwpez
pushed a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #115, chains do not use their local
constants.rs
values, so #131 did not have the desired effect.Would suggest a special Asset Hub 1.1.1 release to get this deployed as soon as possible since a lot of applications were planning on it.