Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[encointer] upgrade to polkadot v1.6.0 #193

Closed
wants to merge 118 commits into from

Conversation

brenzi
Copy link
Contributor

@brenzi brenzi commented Feb 20, 2024

based on #159

Encointer pallets 5.x.x all depend on polkadot-v1.6.0 crates.io releases
(No changes of pallet functionality)
see: encointer/pallets#370

hint: this version of encointer pallets is compatible with polkadot-v1.7.0 as none of the deps have been bumped upstream

[pallet_identity] removed `FieldDeposit`, `MaxAdditionalFields`, added `ByteDeposit`
fix import `simple` -> `legacy`
…: `common` to `common` and `chains`

chore: remove unneeded deps with `cargo machete` for integration tests
@acatangiu
Copy link
Contributor

I suggest we merge 159 then this one, squashing them together just creates an even bigger, harder to review PR

Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually the encointer diff is pretty small, we can merge it with #159

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs Outdated Show resolved Hide resolved
@brenzi
Copy link
Contributor Author

brenzi commented Feb 21, 2024

I requested a pull into #159 over at @bkontur 's repo: bkontur#2

@bkontur
Copy link
Contributor

bkontur commented Feb 21, 2024

I requested a pull into #159 over at @bkontur 's repo: bkontur#2

ok, cool, I am busy with other stuff now, but I have this PR in my backlog, don't worry :)

@bkontur bkontur mentioned this pull request Feb 23, 2024
19 tasks
@bkontur
Copy link
Contributor

bkontur commented Feb 26, 2024

@brenzi I will merge Encointer to 1.6 as a bkontur#4 where I took your PR: bkontur#2
so you can close this and start preparing the same bump for 1.7 :) #187

@brenzi brenzi closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants