Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift external deps to the workspace #201

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Feb 26, 2024

Pulling up all external deps to the workspace. Can be reproduced with the latest version of Zepter (1.3.1):

cargo upgrade -p pallet-xcm@8.0.4
zepter transpose dependency lift-to-workspace "regex:.*" --fix --version-resolver=unambiguous --source-location=remote

This is a No-OP change and can be verified with:

git checkout -q main
cargo tree -e features > main.out

git checkout -q oty-lift-deps-to-workspace
cargo tree -e features | diff main.out -

# No print - empty diff
  • Does not require a CHANGELOG entry

@ggwpez ggwpez force-pushed the oty-lift-deps-to-workspace branch 2 times, most recently from 9c6fb16 to 6732729 Compare February 28, 2024 22:50
@ggwpez ggwpez force-pushed the oty-lift-deps-to-workspace branch 2 times, most recently from 8b871af to fd7cd6f Compare March 5, 2024 15:00
@ggwpez ggwpez requested a review from bkchr March 6, 2024 11:59
@ggwpez ggwpez marked this pull request as ready for review March 6, 2024 11:59
@ggwpez ggwpez force-pushed the oty-lift-deps-to-workspace branch from 4e82599 to dc86fa1 Compare March 12, 2024 13:16
@ggwpez ggwpez force-pushed the oty-lift-deps-to-workspace branch 2 times, most recently from ab4db6c to 2d4a1b9 Compare March 25, 2024 13:24
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
…ion-resolver=unambiguous --source-location=remote

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez force-pushed the oty-lift-deps-to-workspace branch from 2d4a1b9 to 8978346 Compare March 27, 2024 11:37
@ggwpez ggwpez added the please-review Change is ready for review. label Mar 27, 2024
@ggwpez ggwpez changed the title Lift all deps to the workspace Lift external deps to the workspace Mar 27, 2024
Cargo.lock Outdated
version = "8.0.4"
version = "8.0.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why downgrade pallet-xcm? 8.0.4 was a needed patch fix

Copy link
Member Author

@ggwpez ggwpez Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks!
Looks like i ran the old command, one crate is on that version so i got mixed up.
PS: Done

Cargo.toml Outdated Show resolved Hide resolved
ggwpez and others added 2 commits March 27, 2024 14:12
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member Author

ggwpez commented Mar 27, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit ebecd54 into main Mar 27, 2024
35 of 36 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@ggwpez ggwpez deleted the oty-lift-deps-to-workspace branch March 27, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please-review Change is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants