-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update runtime weights for 1.2.0 #223
Update runtime weights for 1.2.0 #223
Conversation
Btw |
Relates to: #223 A type alias `type Nis = pallet_balances::Pallet::<Runtime, NisCounterpartInstance>;` for the second `pallet_balances` instance was introduced [here](#58). Unfortunately, nobody (including myself) realized that `Nis` is also used for `[pallet_nis, Nis]`. As a result, the benchmark for `pallet_nis` runs as if it were for `pallet_balances`, and the result can be seen here: [link](3bb9a02#diff-9bfa230a9b7f40866df3f84e81dfea72a64cc31bd9ef6e594c3d43582ba76522). Therefore, this PR fixes this anomaly. <!-- Remember that you can run `/merge` to enable auto-merge in the PR --> <!-- Remember to modify the changelog. If you don't need to modify it, you can check the following box. Instead, if you have already modified it, simply delete the following line. --> - [x] Does not require a CHANGELOG entry --------- Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming the weight regressions are clarified
…porMessage` handlers: https://github.com/polkadot-fellows/runtimes/pull/159/files#diff-d2ccb0e6ba82a0a63933d17d80d3ecc3a6043d041edd954791076d871fb395acR279-R280 https://github.com/polkadot-fellows/runtimes/pull/223/files#diff-9462f9c932d2d39defa28ae668aea685d928545f874f93c45c550382eb350525R357-R358
/merge |
Enabled Available commands
For more information see the documentation |
L.E.: patch fix removes extra/wrong extrinsinc weight being added on top of benchmarked weight, so in the end we have larger benchmarked weight (which is correct following benchmarking accuracy improvements), but overall lower extrinsic fees 👍 |
522df29
into
polkadot-fellows:main
Relates to: #140
Chain-specs generated from the commit:
f5aeb7e8cc024a17a42ca547645f25f2ae28e4f4
.Polkadot binary used:
TODO
pallet_xcm_benchmarks_fungible.rs
to diffs - Missing other benchmarks fromweights/xcm/pallet_xcm_benchmarks_fungible.rs
ggwpez/substrate-weight-compare#60polkadot
binary from "lastest release- v1.8.0 " or "latest compatible bump release - v1.7.2" ?set_candidacy_bond
Investigate too big change for benchmarkset_candidacy_bond
for 1.2.0 release #230teleport
/reserver_assets_transfer
(they were not regenerated with v1.1.2 + compare with regenerated in polkadot-sdk) Investigate too big change for benchmarkteleport_assets
/reserve_transfer_assets
for 1.2.0 release #231The comparison of this branch with
release-v1.1.2
(latest release)Note:
Change [%]
has threashold 5, so it show only if change is more than5%
or less than-5%
.Polkadot weights
Kusama weights
AssetHubPolkadot weights
AssetHubKusama
BridgeHubPolkadot
BridgeHubKusama
Collectives weights
Encointer weights
Glutton Kusama weights