-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 2 of People Chain Launch #246
Phase 2 of People Chain Launch #246
Conversation
CHANGELOG.md
Outdated
@@ -4,6 +4,10 @@ Changelog for the runtimes governed by the Polkadot Fellowship. | |||
|
|||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
|
|||
## [1.2.1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you want to trigger a release immediately? Should work, just needs a date now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until we are sure that this does not need to be done again: #263
@s0me0ne-unkn0wn do we have to bump the versions again?
We're limiting the migration by the version FROM which we're upgrading, so it doesn't matter if we upgrade 1.1.3 -> 1.2.0 or 1.1.3 -> 1.2.1, it will work fine. And it will not trigger the migration again if we upgrade 1.2.0 -> 1.2.1. So everything is sound IIUC. |
These changes need to be applied after 1.2.0, so it will definitely be 1.2.0 -> 1.2.1. So should we branch off from v1.2.0 or is it OK to release this from master with 263 in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it should be fine as long as we dont have to retract one of the 1.1.3 -> *
runtime upgrades.
These changes need to be applied after 1.2.0, so it will definitely be 1.2.0 -> 1.2.1. So should we branch off from v1.2.0 or is it OK to release this from master with 263 in?
263 is in 1.2.0 already, should be as intended.
Ah I lazily did not check, I just saw it was after the "Triggers 1.2.0 Release" commit. |
/merge |
Enabled Available commands
For more information see the documentation |
5cd9e70
into
polkadot-fellows:main
Do not merge until after the 1.2.0 release. These runtimes should be applied first to the Kusama Relay Chain (after People genesis) and then to the People Chain (after migration is complete).
See details: https://forum.polkadot.network/t/people-chain-launch-and-identity-migration-plan/5930