Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 2 of People Chain Launch #246

Merged

Conversation

joepetrowski
Copy link
Contributor

Do not merge until after the 1.2.0 release. These runtimes should be applied first to the Kusama Relay Chain (after People genesis) and then to the People Chain (after migration is complete).

See details: https://forum.polkadot.network/t/people-chain-launch-and-identity-migration-plan/5930

CHANGELOG.md Outdated
@@ -4,6 +4,10 @@ Changelog for the runtimes governed by the Polkadot Fellowship.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [1.2.1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you want to trigger a release immediately? Should work, just needs a date now.

CHANGELOG.md Show resolved Hide resolved
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until we are sure that this does not need to be done again: #263
@s0me0ne-unkn0wn do we have to bump the versions again?

@s0me0ne-unkn0wn
Copy link
Contributor

@s0me0ne-unkn0wn do we have to bump the versions again?

We're limiting the migration by the version FROM which we're upgrading, so it doesn't matter if we upgrade 1.1.3 -> 1.2.0 or 1.1.3 -> 1.2.1, it will work fine. And it will not trigger the migration again if we upgrade 1.2.0 -> 1.2.1. So everything is sound IIUC.

@joepetrowski
Copy link
Contributor Author

We're limiting the migration by the version FROM which we're upgrading, so it doesn't matter if we upgrade 1.1.3 -> 1.2.0 or 1.1.3 -> 1.2.1, it will work fine. And it will not trigger the migration again if we upgrade 1.2.0 -> 1.2.1. So everything is sound IIUC.

These changes need to be applied after 1.2.0, so it will definitely be 1.2.0 -> 1.2.1. So should we branch off from v1.2.0 or is it OK to release this from master with 263 in?

Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it should be fine as long as we dont have to retract one of the 1.1.3 -> * runtime upgrades.

These changes need to be applied after 1.2.0, so it will definitely be 1.2.0 -> 1.2.1. So should we branch off from v1.2.0 or is it OK to release this from master with 263 in?

263 is in 1.2.0 already, should be as intended.

@joepetrowski
Copy link
Contributor Author

263 is in 1.2.0 already, should be as intended.

Ah I lazily did not check, I just saw it was after the "Triggers 1.2.0 Release" commit.

@joepetrowski
Copy link
Contributor Author

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) April 10, 2024 06:46
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot merged commit 5cd9e70 into polkadot-fellows:main Apr 10, 2024
34 of 35 checks passed
@joepetrowski joepetrowski deleted the people-phase-2 branch April 10, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants