Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh weights for pallet_treasury and pallet_asset_conversion for 1.2.0 release #256

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Mar 27, 2024

Chain specs are based on the commit: bc9491d:

  • Does not require a CHANGELOG entry

The comparison of this branch with main

Polkadot

Just small changes, I had to adjust the threshold from the default 5 to 0.1 to see the changes.

subweight compare commits \
         --path-pattern "./relay/polkadot/**/weights/**/*.rs" \
         --format markdown --no-color \
          --change added changed \
         --method asymptotic --ignore-errors --threshold 0.1 \
         remotes/polkadot-fellows/main \
         origin/bko-weights
File Extrinsic Old New Change [%]
relay/polkadot/src/weights/pallet_treasury.rs approve_proposal 168.49us 169.27us +0.46
relay/polkadot/src/weights/pallet_treasury.rs spend 266.62us 267.67us +0.39
relay/polkadot/src/weights/pallet_treasury.rs on_initialize_proposals 40.67ms 40.73ms +0.13
relay/polkadot/src/weights/pallet_treasury.rs check_status 271.60us 270.88us -0.26

Kusama

Just small changes, I had to adjust the threshold from the default 5 to 0.1 to see the changes.

subweight compare commits \
         --path-pattern "./relay/kusama/**/weights/**/*.rs" \
         --format markdown --no-color \
          --change added changed \
         --method asymptotic --ignore-errors --threshold 0.1 \
         remotes/polkadot-fellows/main \
         origin/bko-weights
File Extrinsic Old New Change [%]
relay/kusama/src/weights/pallet_treasury.rs spend 266.81us 267.89us +0.40
relay/kusama/src/weights/pallet_treasury.rs approve_proposal 170.40us 170.81us +0.24
relay/kusama/src/weights/pallet_treasury.rs propose_spend 246.66us 246.27us -0.16
relay/kusama/src/weights/pallet_treasury.rs on_initialize_proposals 40.95ms 40.88ms -0.18
relay/kusama/src/weights/pallet_treasury.rs reject_proposal 286.94us 284.91us -0.71

Collectives-polkadot

Just small changes, I had to adjust the threshold from the default 5 to 0.1 to see the changes.

subweight compare commits \
         --path-pattern "./system-parachains/collectives/collectives-polkadot/**/weights/**/*.rs" \
         --format markdown --no-color \
          --change added changed \
         --method asymptotic --ignore-errors --threshold 0.1 \
         remotes/polkadot-fellows/main \
         origin/bko-weights
File Extrinsic Old New Change [%]
system-parachains/collectives/collectives-polkadot/src/weights/pallet_treasury.rs spend 266.11us 267.90us +0.67
system-parachains/collectives/collectives-polkadot/src/weights/pallet_treasury.rs void_spend 136.47us 137.12us +0.48
system-parachains/collectives/collectives-polkadot/src/weights/pallet_treasury.rs check_status 273.70us 274.38us +0.25
system-parachains/collectives/collectives-polkadot/src/weights/pallet_treasury.rs spend_local 360.21us 359.81us -0.11
system-parachains/collectives/collectives-polkadot/src/weights/pallet_treasury.rs approve_proposal 168.75us 168.53us -0.13

AssetHubKusama

subweight compare commits \
         --path-pattern "./system-parachains/asset-hubs/asset-hub-kusama/**/weights/**/*.rs" \
         --format markdown --no-color \
          --change added changed \
         --method asymptotic --ignore-errors  \
         remotes/polkadot-fellows/main \
         origin/bko-weights
File Extrinsic Old New Change [%]
system-parachains/asset-hubs/asset-hub-kusama/src/weights/pallet_assets_pool.rs refund 264.63us 403.23us +52.37
system-parachains/asset-hubs/asset-hub-kusama/src/weights/pallet_assets_pool.rs touch 265.89us 403.72us +51.84
system-parachains/asset-hubs/asset-hub-kusama/src/weights/pallet_asset_conversion.rs create_pool 574.29us 728.94us +26.93

AssetHubPolkadot

subweight compare commits \
         --path-pattern "./system-parachains/asset-hubs/asset-hub-polkadot/**/weights/**/*.rs" \
         --format markdown --no-color \
          --change added changed \
         --method asymptotic --ignore-errors  \
         remotes/polkadot-fellows/main \
         origin/bko-weights
File Extrinsic Old New Change [%]
system-parachains/asset-hubs/asset-hub-polkadot/src/weights/pallet_assets_pool.rs refund 264.91us 402.91us +52.09
system-parachains/asset-hubs/asset-hub-polkadot/src/weights/pallet_assets_pool.rs touch 266.41us 403.36us +51.40
system-parachains/asset-hubs/asset-hub-polkadot/src/weights/pallet_asset_conversion.rs create_pool 977.14us 727.48us -25.55
system-parachains/asset-hubs/asset-hub-polkadot/src/weights/pallet_asset_conversion.rs swap_tokens_for_exact_tokens 1.57ms 590.36us -62.48
system-parachains/asset-hubs/asset-hub-polkadot/src/weights/pallet_asset_conversion.rs swap_exact_tokens_for_tokens 1.59ms 590.42us -62.77
system-parachains/asset-hubs/asset-hub-polkadot/src/weights/pallet_assets_pool.rs create 135.77us 0ps -100.00

@bkontur bkontur mentioned this pull request Mar 27, 2024
19 tasks
@bkontur
Copy link
Contributor Author

bkontur commented Mar 27, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) March 27, 2024 10:42
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@bkontur bkontur disabled auto-merge March 27, 2024 10:44
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bkontur
Copy link
Contributor Author

bkontur commented Mar 27, 2024

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) March 27, 2024 15:22
@fellowship-merge-bot fellowship-merge-bot bot merged commit 17fe1b1 into polkadot-fellows:main Mar 27, 2024
33 of 34 checks passed
@bkontur bkontur deleted the bko-weights branch April 2, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants