The Ambassador Program #291

muharem · 2024-04-26T11:29:21Z

The Ambassador Program on Polkadot Collectives Parachain

Closes #264
Reflects https://polkadot.polkassembly.io/referenda/487

On Chain Structure

The on-chain program consists of three ranks:

Ambassadors (rank 1);
Senior Ambassadors (rank 2);
Head Ambassadors (rank 3);

Each rank has a corresponding Origin (Ambassador, SeniorAmbassador, HeadAmbassador), which represents the collective voice of members of that rank and above.

Referendum

The AmbassadorReferenda instance of referenda pallet consists of three tracks, each corresponding to an Origin. A referendum taken on senior ambassador track invites all members from rank 2 or above to vote and commands SeniorAmbassadors Origin. The referendum proposal can be submitted by any member from first rank or above.

Membership Management

Both Root and FellowshipAdmin Origins, commanded via public Polkadot referendum, can promote or demote members to and from any rank. Members themselves hold the power to promote or demote via program's referendum pallet instance. Senior members can promote candidates to the first rank, while head members can promote all members up to the second rank. Any member of the program can induct a new member to the collective as a candidate (0 rank). Promotion to the Head Ambassador or demotion from can be made with Polkadot OpenGov.

Sub-Treasury

The program operates its own sub-treasury, managed by OpenGov or Senior and Head Ambassadors. Members can spend up to 1k DOT on Senior Ambassador track and up to 10k DOT on Head Ambassadors track.

Additional Functionality

The AmbassadorCore instance of core fellowship pallet decorates the ranked collectives pallet with features like salary determination, activity/passivity registration, and the handling of promotion and demotion periods. Those parameters can be set by OpenGov or Head Ambassadors.

Periodic salaries in USDt, payable on Asset Hub, are introduced through the salary pallet. The total monthly budget is set to ( 10k * 21 ) USDt.

Rules that are not enforced on chain

21 members at Head Ambassador rank;
candidates wont be removed automatically in 6 month;
collectives with less than 10 HA can onboard new members;

Source: https://polkadot.polkassembly.io/referenda/487cccccbegbjkdfhkrgekidfrhvkvilnbcvuitgnrcnkrr

…ogram-2

muharem · 2024-04-28T09:07:32Z

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

+/// - Each member with an excess rank of 0 gets 1 vote;
+/// - ...with an excess rank of 1 gets 5 votes;
+/// - ...with an excess rank of 2 gets 10 votes;
+/// - ...with an excess rank of 3 gets 15 votes;


there is no way with a current version of the pallet to describe the weights for the votes the way it is manifested (but it is possible if we update this convert contract in the pallet).
here I keep the proportion for SA and HA as in the document, but A gets less.

Interesting, thought it would be possible to basically hardcode a rank => weight table. I think the intent of the manifesto is that HA should be much more powerful because they can be highly outnumbered but are selected by general referendum. As in:

Can only be 21 HAs, but they are selected by all Polkadot holders,

Can be potentially 10s or 100s of SAs.

So for SA to overrule HA, it should take an extreme majority of SA.

Here I still keep proposition as in manifesto for SA vs HA, which is 1:5, because one excess rank gives you 5 more. But promotion changes for A vs SA, and A vs HA, 1:5 and 1:10 respectively which I think is less important.

muharem · 2024-04-28T09:09:20Z

system-parachains/collectives/collectives-polkadot/src/ambassador/tracks.rs

+					},
+					min_support: pallet_referenda::Curve::LinearDecreasing {
+						length: Perbill::from_percent(100),
+						floor: Perbill::from_percent(0),


this is according tot he manifesto, but are we sure we wanna allow the floor support as 0?

I don't mind 0, we should force engagement, even if it's a default vote of Nay. But not a strong opinion either way.

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

muharem · 2024-04-28T09:13:05Z

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

+		>,
+		EitherOf<
+			MapSuccess<SeniorAmbassadors, Replace<ConstU128<{ 1 * GRAND }>>>,
+			MapSuccess<HeadAmbassadors, Replace<ConstU128<{ 10 * GRAND }>>>,


in manifesto we have noting about an upper limit spend for HA, but I believe there should be some. this is open for conversation.

I think we can start with this. If they come out opening 10k+ DOT proposals in the first few months then probably something is fishy.

joepetrowski · 2024-04-29T05:18:42Z

system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs

+pub struct AmbassadorEntities;
+impl Contains<Location> for AmbassadorEntities {


This doesn't have anything for the BodyId. I guess they have no power outside their Treasury/Salary so maybe it is not important. We just have to make sure to add this if they ever do get some new power or need that origin. Perhaps put it in docs?

Right. I cannot come up with a good location for such doc. If some collective plurality gets to manage something in Asset Hub, an engineer will need only to update an ensure origin impl for some pallet. I think an engineer should keep in mind that xcm execution is not for free by default.
We can also just grant a free xcm execution for all Collectives Parachain pluralities, but I am not sure if that will be true for all future pluralities.

joepetrowski · 2024-04-29T05:23:13Z

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

+/// - Each member with an excess rank of 0 gets 1 vote;
+/// - ...with an excess rank of 1 gets 5 votes;
+/// - ...with an excess rank of 2 gets 10 votes;
+/// - ...with an excess rank of 3 gets 15 votes;


Interesting, thought it would be possible to basically hardcode a rank => weight table. I think the intent of the manifesto is that HA should be much more powerful because they can be highly outnumbered but are selected by general referendum. As in:

Can only be 21 HAs, but they are selected by all Polkadot holders,

Can be potentially 10s or 100s of SAs.

So for SA to overrule HA, it should take an extreme majority of SA.

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

joepetrowski · 2024-04-29T05:28:20Z

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

+		>,
+		EitherOf<
+			MapSuccess<SeniorAmbassadors, Replace<ConstU128<{ 1 * GRAND }>>>,
+			MapSuccess<HeadAmbassadors, Replace<ConstU128<{ 10 * GRAND }>>>,


I think we can start with this. If they come out opening 10k+ DOT proposals in the first few months then probably something is fishy.

joepetrowski · 2024-04-29T05:30:23Z

system-parachains/collectives/collectives-polkadot/src/ambassador/tracks.rs

+					min_support: pallet_referenda::Curve::LinearDecreasing {
+						length: Perbill::from_percent(100),
+						floor: Perbill::from_percent(0),
+						ceil: Perbill::from_percent(50),


Shouldn't this be like the Fellowship?

Suggested change

ceil: Perbill::from_percent(50),

ceil: Perbill::from_percent(100),

this is how I read it from manifesto

All tracks should have a voting period of seven days, with a linear curve such that greater than 50% turnout unanimously in favor can pass a motion at its start and a simple majority of voters at the end (as in, no turnout requirement).

Ah, you are correct. Maybe the Fellowship is wrong. 100% support doesn't make sense.

joepetrowski · 2024-04-29T05:31:27Z

system-parachains/collectives/collectives-polkadot/src/ambassador/tracks.rs

+					},
+					min_support: pallet_referenda::Curve::LinearDecreasing {
+						length: Perbill::from_percent(100),
+						floor: Perbill::from_percent(0),


I don't mind 0, we should force engagement, even if it's a default vote of Nay. But not a strong opinion either way.

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

…ogram-2

Doordashcon · 2024-05-10T04:27:42Z

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

+	type RuntimeEvent = RuntimeEvent;
+	// Promotions must be done through the [`crate::AmbassadorCore`] pallet instance.
+	#[cfg(not(feature = "runtime-benchmarks"))]
+	type PromoteOrigin = frame_support::traits::NeverEnsureOrigin<Rank>;


Should be RemoveOrigin?

github-actions · 2024-05-17T16:02:56Z

Review required! Latest push from author must always be reviewed

acatangiu · 2024-05-20T15:45:27Z

/merge

joepetrowski · 2024-05-20T16:40:54Z

/merge

fellowship-merge-bot · 2024-05-20T16:42:16Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

ambassador program module

8810de4

muharem marked this pull request as draft April 26, 2024 18:36

muharem added 4 commits April 28, 2024 11:48

fixes

2c4cdd9

weights

7abbd68

changelog

897dc9a

Merge remote-tracking branch 'origin/main' into muharem-ambassador-pr…

d542fc1

…ogram-2

muharem commented Apr 28, 2024

View reviewed changes

muharem marked this pull request as ready for review April 28, 2024 09:16

muharem mentioned this pull request Apr 28, 2024

The Ambassador Program #84

Closed

joepetrowski reviewed Apr 29, 2024

View reviewed changes

joepetrowski mentioned this pull request May 1, 2024

Proposing: v1.2.4 Release #288

Closed

10 tasks

muharem and others added 2 commits May 2, 2024 11:20

Apply suggestions from code review

9c44086

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into muharem-ambassador-pr…

a1cd819

…ogram-2

joepetrowski approved these changes May 7, 2024

View reviewed changes

Doordashcon reviewed May 10, 2024

View reviewed changes

Merge branch 'main' into muharem-ambassador-program-2

71fb353

github-actions bot requested a review from joepetrowski May 17, 2024 16:02

joepetrowski approved these changes May 17, 2024

View reviewed changes

joepetrowski and others added 3 commits May 19, 2024 15:20

clippy

1dd72eb

Merge branch 'main' into muharem-ambassador-program-2

7132bbe

Merge branch 'main' into muharem-ambassador-program-2

53b95a3

acatangiu approved these changes May 20, 2024

View reviewed changes

fellowship-merge-bot bot merged commit b0a3eff into polkadot-fellows:main May 20, 2024
37 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The Ambassador Program #291

The Ambassador Program #291

muharem commented Apr 26, 2024 •

edited

Loading

muharem Apr 28, 2024

joepetrowski Apr 29, 2024

muharem May 2, 2024

muharem Apr 28, 2024

joepetrowski Apr 29, 2024

muharem Apr 28, 2024

joepetrowski Apr 29, 2024

joepetrowski Apr 29, 2024

muharem May 2, 2024

joepetrowski Apr 29, 2024

joepetrowski Apr 29, 2024

joepetrowski Apr 29, 2024

muharem May 2, 2024

joepetrowski May 2, 2024

joepetrowski Apr 29, 2024

Doordashcon May 10, 2024 •

edited

Loading

github-actions bot commented May 17, 2024

acatangiu commented May 20, 2024

joepetrowski commented May 20, 2024

fellowship-merge-bot bot commented May 20, 2024

		pub struct AmbassadorEntities;
		impl Contains<Location> for AmbassadorEntities {

	ceil: Perbill::from_percent(50),
	ceil: Perbill::from_percent(100),

The Ambassador Program #291

The Ambassador Program #291

Conversation

muharem commented Apr 26, 2024 • edited Loading

The Ambassador Program on Polkadot Collectives Parachain

On Chain Structure

Referendum

Membership Management

Sub-Treasury

Additional Functionality

Rules that are not enforced on chain

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Doordashcon May 10, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented May 17, 2024

acatangiu commented May 20, 2024

joepetrowski commented May 20, 2024

fellowship-merge-bot bot commented May 20, 2024

muharem commented Apr 26, 2024 •

edited

Loading

Doordashcon May 10, 2024 •

edited

Loading