-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull all dependencies to the workspace #314
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
zepter transpose dep lift-to-workspace 'regex:.*' --fix Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty!
Review required! Latest push from author must always be reviewed |
], workspace = true } | ||
cumulus-pallet-xcm = { workspace = true } | ||
cumulus-pallet-xcmp-queue = { workspace = true } | ||
cumulus-primitives-aura = { workspace = true } | ||
cumulus-primitives-core = { workspace = true } | ||
cumulus-primitives-utility = { workspace = true } | ||
parachain-info = { package = "staging-parachain-info", default-features = false, version = "0.8.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the workspace dependencies feature is cool. The potential problem I see is with Encointer and its pallets, which use a different version of the Polkadot SDK. When we upgrade to a new version of the Polkadot SDK, Encointer is unlikely to compile. As a result, we won't be able to create a new release unless Encointer updates its pallets to the same Polkadot SDK version.
Therefore, it's questionable whether using workspace dependencies is a good idea for Encointer at this time. But let's give it a try and see what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay i did not think about this. It basically means that we need to update the encointer pallets in advance to the version of the SDK that we plan to use next.
Co-authored-by: ordian <noreply@reusable.software>
/merge |
Enabled Available commands
For more information see the documentation |
Changes:
This is a preliminary to updating to the new SDK version as we currently use conflicting aliases for a few packages while packages are not able to rename workspace deps, see rust-lang/cargo#12546
This is a No-OP change, as can be verified with this: