Remove ChildSystemParachainAsSuperuser from Kusama runtime + align "System" vs "common good" terminology
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
changed the title
ChildSystemParachainAsSuperuser from Kusama runtime + aligned "System" vs "common good" terminologyChildSystemParachainAsSuperuser from Kusama runtime + align "System" vs "common good" terminology
fellowship-merge-bot bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
…depend on crates.io versions) (#45) ## Summary This PR proposes several changes. - The alignment of the terminology used for "common-good" and "system" parachains in the Polkadot ecosystem, as discussed in [PR#1406](paritytech/polkadot-sdk#1406). - Additionally, it suggests the removal of the `ChildSystemParachainAsSuperuser` feature from the Kusama runtime, as mentioned in a comment on the same PR [comment link](paritytech/polkadot-sdk#1406 (comment)). - Relax `force_default_xcm_version` in `SafeCallFilter` for system parachains - based on paritytech/polkadot-sdk#2385 - Add `Storage` item to `PolkadotXcm` pallet definition for BridgeHubs (now we cannot see storage items for `pallet_xcm` in polkadot.js) - based on paritytech/polkadot-sdk#2385 ## Explanation A significant [change of PR#1406](https://github.com/paritytech/polkadot-sdk/pull/1406/files#diff-0b7b4f5b962a18ce980354592b55ab2a27b5a2e9f6f8089ec803ca73853e8583L202-R224) is the redefinition of what constitutes a "system" parachain. Previously, a "system" parachain was identified with `para_id <= 1000`. However, the [PR#1406](paritytech/polkadot-sdk#1406) changed a definition, considering a "system" parachain to have `para_id <= 1999`. One consequence of this change is the reconsideration of the [`ChildSystemParachainAsSuperuser`](https://github.com/paritytech/polkadot-sdk/blob/a50e6ba7af50a4be9ae78ebb90e86a61f3dd85e1/polkadot/xcm/xcm-builder/src/origin_conversion.rs#L72-L88) feature. This feature relies on the [`is_system`](https://github.com/paritytech/polkadot-sdk/blob/a50e6ba7af50a4be9ae78ebb90e86a61f3dd85e1/polkadot/parachain/src/primitives.rs#L216-L226) function, which, in turn, depends on the para_id of a parachain to determine "system" status. However, further examination has revealed that there is no known scenario in which a system parachain would need to call the Kusama runtime with `RuntimeOrigin::root()` privileges. Consequently, maintaining the `ChildSystemParachainAsSuperuser` feature in the Kusama runtime is deemed unnecessary. ## References - [GitHub Pull Request #1406](paritytech/polkadot-sdk#1406) - [GitHub Pull Request #2385](paritytech/polkadot-sdk#2385) - Redo of #32 on main. --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes the alignment of the terminology used for "common-good" and "system" parachains in the Polkadot ecosystem, as discussed in PR#1406. Additionally, it suggests the removal of the
ChildSystemParachainAsSuperuserfeature from the Kusama runtime, as mentioned in a comment on the same PR comment link.Explanation
A significant change of PR#1406 is the redefinition of what constitutes a "system" parachain. Previously, a "system" parachain was identified with
para_id <= 1000. However, the PR#1406 changed a definition, considering a "system" parachain to havepara_id <= 1999.One consequence of this change is the reconsideration of the
ChildSystemParachainAsSuperuserfeature. This feature relies on theis_systemfunction, which, in turn, depends on the para_id of a parachain to determine "system" status. However, further examination has revealed that there is no known scenario in which a system parachain would need to call the Kusama runtime withRuntimeOrigin::root()privileges. Consequently, maintaining theChildSystemParachainAsSuperuserfeature in the Kusama runtime is deemed unnecessary.References