Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Member Request #7

Merged
merged 6 commits into from
Oct 2, 2022
Merged

Member Request #7

merged 6 commits into from
Oct 2, 2022

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Sep 27, 2022

rphmeier
rphmeier previously approved these changes Sep 27, 2022
@rphmeier rphmeier dismissed their stale review September 27, 2022 17:17

(adjusting to manifesto requirements)

@rrtti
Copy link
Contributor

rrtti commented Sep 27, 2022

Just to note: Manifesto sections 6.3, 6.4, 6.5 and 6.6 all state that a time period of 12 months should generally be expected to have elapsed since attaining the prior rank, leading to a reasonable minimum period of 1 year since fulfilling I Dan requirements for attaining II Dan, 2 years since fulfilling I Dan requirements for attaining III Dan and so on.

Copy link
Member

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think III Dan would be more appropriate. You have been a great contributor so far and I think you have enough time under your belt (as one of the early parachain developers joining the community). That said, I feel like there wasn't enough foundational work done yet and ownership (which is understandable as your main focus so far was parachain development).

Copy link
Collaborator

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support your request for IV Dan.

I think you have shown good knowledge of the internal of FRAME over the years and as you also have presented on your own you have done quite some things.

@xlc
Copy link
Contributor Author

xlc commented Sep 29, 2022

I will say I have some impact on the foundation of Substrate (e.g. paritytech/substrate#1514, paritytech/substrate#1328) and have some ownership of some work in Substrate (e.g. bounties pallet). I do get asked by others for review & suggestions for PRs in Substrate. This twitter thread also explains some of them: https://twitter.com/XiliangChen/status/1486652476375777286

@rphmeier
Copy link
Collaborator

Rather than (just) plentiful incremental low-level improvements to the
protocol, substantial valuable individual contributions to the (r)evolution of the protocol should have been demonstrated
through the design, architecture and/or implementation of key future components which were (ultimately) found valuable
by the Fellowship. Rather than comprehension, their ability to experiment, design and build new technology must be
beyond question and their truly novel ideas and designs must be of a consistently high quality and at least occasionally
beyond the imaginations of those with higher rank.

The type-carrying metadata definitely fits this bill.

@rrtti rrtti self-requested a review October 2, 2022 20:13
@gavofyork gavofyork merged commit fbc4275 into polkadot-fellows:main Oct 2, 2022
@xlc xlc deleted the patch-1 branch October 2, 2022 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants