-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
(adjusting to manifesto requirements)
Just to note: Manifesto sections 6.3, 6.4, 6.5 and 6.6 all state that a time period of 12 months should generally be expected to have elapsed since attaining the prior rank, leading to a reasonable minimum period of 1 year since fulfilling I Dan requirements for attaining II Dan, 2 years since fulfilling I Dan requirements for attaining III Dan and so on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I think III Dan would be more appropriate. You have been a great contributor so far and I think you have enough time under your belt (as one of the early parachain developers joining the community). That said, I feel like there wasn't enough foundational work done yet and ownership (which is understandable as your main focus so far was parachain development).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support your request for IV Dan.
I think you have shown good knowledge of the internal of FRAME over the years and as you also have presented on your own you have done quite some things.
I will say I have some impact on the foundation of Substrate (e.g. paritytech/substrate#1514, paritytech/substrate#1328) and have some ownership of some work in Substrate (e.g. bounties pallet). I do get asked by others for review & suggestions for PRs in Substrate. This twitter thread also explains some of them: https://twitter.com/XiliangChen/status/1486652476375777286 |
The type-carrying metadata definitely fits this bill. |
Range of ranks: 4
First non trivial PR: paritytech/substrate#1362
Some substantial PRs:
My PRs:
Other than just code contributions, I also raise feature requests, bug reports, participate issue discussions and provide suggestions to Substrate from an ecosystem developer perspective.
Some other contributions: