Install Review GitHub app and set up secrets #65
Comments
|
Who is admin over this org? @ggwpez @bkchr @shawntabrizi |
|
I'm confused. This is the wrong repo? The bot should be installed for the |
I understood from this comment between @acatangiu and @rzadp that xcm-format would be migrated into this repository:
Was there been a different decision that is not reflected inside the issue? |
|
We want to run the review bot on the https://github.com/polkadot-fellows/xcm-format repo, not this repo. (point 2 in #62 (comment)) |
|
Ok, I got confused by the phrasing in the next comment. @bkchr could you migrate this issue to the The requirements are still the same. Thanks! |
|
@Bullrich can you give me the link to the docs on how to create the app ID and key? Then I get this done |
|
@pavelsupr manages the bot in Parity's org, I remember that he provided both the app id and generated a private key when we installed it in the runtimes repository. Pavel, could you please generate a new private key and share both the key and the app id with Basti for the app Once @bkchr has these, he can set them as repository secrets and then I can port the Review-Bot configuration file. Thanks! |
|
Ty @pavelsupr. @Bullrich I created the env variables as requested. |
Now that polkadot-fellows#65 has been resolved, review-bot can be implemented. The following configuration has been provided in the file, but it can be changed if you disagree with the content: ### CI Files Requires **1 dan 3** to review it and a total of **15 points** to merge. Some possible combinations are: - 1 dan6 - 1 dan5 & 1 dan3 - 3 dan3 - 1 dan4 & 1 dan3 & 1 dan2 ### Proposals Requires at least **2 dan 2** to review it and a total of **10 points** to merge. Some possible combinations are: - 1 `dan5` && any rank - 2 `dan3`. - 5 `dan2`. - 1 `dan2` and 8 `dan1`. ### General files Requires at least **2 dan 1** to review it and a total of **4 points** to merge. Some possible combinations are: - 1 `dan3` or above. - 4 `dan1`. - 2 `dan2`.
Thank you. I created #66 I tried to use more of the score system to make it more attractive for lower ranks to participate, but feel free to request any changes. |
To properly install review-bot, like requested in #62 (comment), we first need to have the GitHub app used in the runtimes repository.
As you can see in the GitHub Action Review Bot, the secrets
REVIEW_APP_IDandREVIEW_APP_KEYhave been installed in that repository.We need an admin to:
REVIEW_APP_IDsecret in this repository.REVIEW_APP_KEYsecret in this repository.This are the required steps to install Review-Bot.
The text was updated successfully, but these errors were encountered: