-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction-payment runtime API V3 #5430
Add transaction-payment runtime API V3 #5430
Conversation
Weird, at quick glance it does add the right things. (The typegen is only needed for TS developers, so it doesn't need to be run) How are you testing this against a local node? (Which steps?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small linting fixes on quotes, aka ' vs "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just spread into empty object (otherwise it would actually clobber the existing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply same "to-empty-spread" functionality for TransactionPaymentCallApi
Thanks for the help, Jaco! I believe addressed the However, I haven't been able to set up an override for |
Depends on how you want to test. So for my tests above, I have this structure -
So basically the |
Thanks! I was able to test the changes, LGTM now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all-ok. Will wait for the Substrate PR to be merged before merging this one (just in-case there are some changes required there)
Substrate just merged paritytech/substrate#13110 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR is a companion for paritytech/substrate#13110. It adds the same API definitions to
pallet-transaction-payment
introduced there. The API version is being rev'ed from V2 -> V3.I have not been able to get this to work and could use a pointer.
When run my local changes here against a node/runtime supporting the new V3, the entire
api.call.transactionPaymentApi
is missing (undefined
), likely the same symptom described in the PR above. It seems to work fine for V2.I think I need to run
yarn polkadot-types-from-chain
to generate some code and put it in the right place, but I'm not sure exactly how to invoke this. I could be barking up the wrong tree, of course.