-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elysium networks #10077
base: master
Are you sure you want to change the base?
Elysium networks #10077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes required to make the CI build pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested linting fixes to make CI happy.
Co-authored-by: Jaco <jacogr@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting seems to be passing now (it is generally easier to run them locally, auto-fix takes care of the most)
Last failure is due to alphabetical ordering, see -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an ordering issue indicated on the CI test - https://github.com/polkadot-js/apps/actions/runs/7407424678/job/20332033512?pr=10077#step:4:224
(The conflicts can be resolved by just merging in master)
Add Elysium network in TestNet and MainNet
Hey, @jacogr what if execute the workflow before your approval? This will help to debug things quickly. I executed all step: ['lint', 'test', 'build:code', 'build:i18n', 'build:electron'] @jacogr Please review this Action https://github.com/polkadot-js/apps/actions/runs/7621677199 this is the latest one. https://github.com/polkadot-js/apps/actions/runs/7621677199 |
Add Elysium Networks in TestNet and MainNet