Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for migration ledger app #10777

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Jul 22, 2024

This PR works to give support for the Ledger Migration App.

In the settings you can now toggle which app you would like to use. The options will be the Generic or the Migration.

TODO:

  • When signing with a ledger account - ensure there is a message saying which app the user is using.
  • Display the same as above but for when connecting an account as well.

@TarikGul TarikGul changed the title Add support for legacy and migration ledger app Add support for migration ledger app Jul 24, 2024
Copy link

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TarikGul TarikGul merged commit 003ae66 into master Jul 24, 2024
5 checks passed
@TarikGul TarikGul deleted the tg-ledger-support-migration branch July 24, 2024 16:59
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants