Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter code to make fellowship and ambassador pages to reappear #11022

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

wirednkod
Copy link
Member

I am not sure how needsAccounts work. Based on my undersatnding it should allow for the page to appear if the collective has accounts. But while the collective has accounts it still dissappears.
By removing this boolean - the pages reappear but it would be nice to understand what that flag is doing

cc @TarikGul

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea works for me! Basically needsAccounts means there must be synced account with the instance that polkadot-js is opened in.

So if you have an extension, or ledger accounts connected to apps in that instance it will work.

@TarikGul TarikGul merged commit f49cca6 into master Oct 23, 2024
5 checks passed
@TarikGul TarikGul deleted the nik-fix-dissappeared-collectives branch October 23, 2024 18:37
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants