Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegation UI from Edgeware to Polkadot #9250

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Depth-Hoar
Copy link
Contributor

@Depth-Hoar Depth-Hoar commented Mar 29, 2023

Hello Polkadot Apps maintainers,

I've developed a delegation UI interface for Edgeware that I believe would be a valuable addition to the Polkadot Apps project. I understand that there might be changes required to align it with the project's coding standards, design guidelines, or functionality requirements, and I'm open to any suggestions or modifications.

Here's a brief overview of the features and functionality that the delegation UI interface offers:

  • User-friendly interface: The delegation UI is designed to be intuitive and easy to use, providing users with a seamless experience when delegating their tokens. While allowing the user to see who they are actively delegating to.

I have tested the delegation UI interface thoroughly and have done my best to ensure compatibility with the existing Polkadot Apps project. However, I understand that there might be improvements or changes required before it can be integrated into the main project.

I would greatly appreciate it if you could review my submission and provide feedback. I am more than happy to address any concerns or make the necessary changes as necessary

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, thank you.

CI is quite unhappy with it, however these should all be simple(-ish) fixes.

Overall, don't add this as a seperate app - it really should be integrated with the goverance app as it stands. (So there, we can just replace the existing delegation). An app is more-or-less specific to a pallet, so we want it seamless in there to manage all details around it.

(For delegation, at "some point in the future", it may make sense to also make it available on "app-accounts", but for now best to keep it with governance)

Having said all that (so some tweaks required with just an initial glance), will also pull down and play - although it should be moved, quite happy to explore the direction as you laid out.

@Depth-Hoar Depth-Hoar changed the title Delegation UI from Edeware to Polkadot Delegation UI from Edgeware to Polkadot Mar 30, 2023
Copy link

@sandritis2 sandritis2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edgeware-network:polkadotAppsDelegatePR

@polkadot-js polkadot-js deleted a comment from sandritis2 Apr 2, 2023
@Depth-Hoar
Copy link
Contributor Author

Thank you for the feedback, I understand that you'd like me to integrate the delegation functionality into the existing governance app instead of creating a separate app for it. To make sure I correctly implement the changes, could you please provide more guidance on where the governance app is located within the project structure? Additionally, if you have any specific suggestions on how I should integrate the delegation functionality within the governance app, it would be greatly appreciated. I'll make the necessary changes and update the PR accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants