-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue 9127. teleport reactivated #9529
fix: issue 9127. teleport reactivated #9529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Some small requests around the versioning maintenance.
c04bbaf
to
f2e56e3
Compare
Polkadot and all system chains are now on V3, we really shouldn't use V1 or V2 at all. |
Since as per Joe's comments all are (currently) on V3 could just simplify it completely -
So I guess it could be just as simple as renaming the old key in the message construction to (If anything is not on V3, e.g. have not checked Encointer, just don't allow teleport functionality) |
I updated to xcm V3. The kusama <-> encointer network channel does not support xcm V3 and was therefore deactivated. On Rococo the transfer works from Rococo to Asset Hub but not from Asset Hub to Rococo. Should I disable? Also on Rococo the transferred assets from a parachain to Rococo sometimes don't show up at all, maybe related to this: On Westend, Kusama, Polkadot the transfers worked properly. @jacogr: Could you review again? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
It looks sane, just going through testing through this branch locally (both directions).
PS: I think Rococo is fine to leave as-is. (Since it is a testnet without any funds at risk - since it also evolves quite rapidly, having the functionality available is great, even if it temporaily doesn't quite work as expected).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is great. (And especially for checking/testing on all the affected relays)
The testing on my side went perfectly.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hello Polkadot Apps maintainers
This PR fixes #9127
by using XCM v2 for Kusama and v1 for Polkadot teleports.
v2 is used as default if not otherwise defined.