Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added details for Fennel Network. #9588

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added details for Fennel Network. #9588

wants to merge 1 commit into from

Conversation

Romulus10
Copy link

No description provided.

@Romulus10 Romulus10 mentioned this pull request Jun 15, 2023
Closed
2 tasks
Romulus10
Romulus10 commented Jun 15, 2023
View reviewed changes
packages/apps-config/src/endpoints/testingRelayRococo.ts
info: 'rococoFennel',
paraId: 4261,
providers: {
// Fennel: 'wss://node-1.fennellabs.com' //
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Fennel: 'wss://node-1.fennellabs.com' //
// Fennel: 'wss://rococo.fennellabs.com' //

jacogr
jacogr requested changes Jun 22, 2023
View reviewed changes
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI linting has picked up issues that needs to be resolved.

Additionally, it would seem that ./generated/fennelPNG.js is not available, this is perhaps due to the output from yarn build:images not being committed as part of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacogr jacogr jacogr requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Romulus10 @jacogr