Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ipfs://ipfs/ links #9772

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Support ipfs://ipfs/ links #9772

merged 6 commits into from
Feb 28, 2024

Conversation

jsidorenko
Copy link
Contributor

isIPFS package we use unfortunately can't detect links that start with ipfs://ipfs/.
In this PR I've added a new helper method to clean the link and remove the unsupported prefix.

P. S. Shall we switch to the new nfts pallet? It already has more collections created compared to the old one.
Or we can support both pallets if needed.

@jsidorenko jsidorenko requested a review from jacogr August 9, 2023 15:51
@jacogr
Copy link
Member

jacogr commented Aug 9, 2023

Generally we want to support old and new - however is the “general support chains” are only n new, having the t to clean it up.

@jsidorenko
Copy link
Contributor Author

So you won't be against it if I switch the code to the new pallet?
There will soon be no UIs supporting the uniques pallet, and I think it will get deprecated at some point.
I would also be happy to add the basic UI to create a new collection (and ideally edit it later)

@jsidorenko
A more universal approach
76a98b8
@jsidorenko
Merge branch 'master' into js/better-ipfs-links-support
6e29bab 
# Conflicts:
#	packages/page-nfts/src/AccountItems/useItemsInfos.ts
#	packages/page-nfts/src/useCollectionInfos.ts
@jsidorenko jsidorenko requested a review from jacogr October 18, 2023 10:30
@TarikGul
Copy link
Member

Hey @jsidorenko if you can fix the merge conflict, I can do a review and we can get this in!

@jsidorenko
Merge branch 'master' into js/better-ipfs-links-support
5539107 
# Conflicts:
#	packages/react-hooks/src/useIpfsFetch.ts
@jsidorenko
Chore
ceafff2
@jsidorenko
Copy link
Contributor Author

Hey @jsidorenko if you can fix the merge conflict, I can do a review and we can get this in!

done

@TarikGul
Copy link
Member

Thank you, looks great!

@TarikGul TarikGul merged commit 585662d into polkadot-js:master Feb 28, 2024
5 checks passed
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Mar 1, 2024
@jsidorenko jsidorenko deleted the js/better-ipfs-links-support branch March 1, 2024 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TarikGul TarikGul TarikGul approved these changes

@jacogr jacogr Awaiting requested review from jacogr

Assignees
No one assigned
Labels
None yet
Projects
Polkadot-js general project board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsidorenko @jacogr @TarikGul @polkadot-js-bot