Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pioneer Blockchain to Metaverse.Network Pioneer #9850

Merged
merged 4 commits into from
Sep 10, 2023

Conversation

justinphamnz
Copy link
Contributor

  • Bit.Country team updated the blockchain to correct name of Metaverse.Network Tewai and Metaverse.Network Pioneer

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

CI is failing (tests, see here https://github.com/polkadot-js/apps/actions/runs/6082496456/job/16500405817?pr=9850#step:4:538) since it expects the entries in an alphabetical order. Since the name was changed, this is no longer the case.

Simply move the updated entries down to the correct place and CI will pass, so it can be merged.

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a pain :)

We are still missing one update, since we changed 2 chains, see https://github.com/polkadot-js/apps/actions/runs/6090821827/job/16526358063?pr=9850#step:4:538

@justinphamnz
Copy link
Contributor Author

Sorry to be a pain :)

We are still missing one update, since we changed 2 chains, see https://github.com/polkadot-js/apps/actions/runs/6090821827/job/16526358063?pr=9850#step:4:538

Thanks @jacogr, for reviewing it. All fixed now.

Appreciate your time.

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@jacogr jacogr merged commit 719e277 into polkadot-js:master Sep 10, 2023
5 checks passed
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants