Jlm update for ethereum pair addition

[joelamouche]

When injecting accounts, we only have the address and not the publicKey.
Therefore, we need to support adding a key from address for ethereum addresses

[jacogr]

Since Ethereum addresses are with the checksum encoding, I would not change this. It adds value in the ecosystem.

[joelamouche]

Are you refering to the use of ethereumEncode? Or the conversion? I'm not sure what you mean

[jacogr]

The encoding. So we updated all address outputs here to be non-checksummed. In the Ethereum ecosystem the checksums do add value. If we want non checksum addresses (which we certainly don't), the correct place would be to encode it without. In this case however, we don't want to do this.

1. the address output should output the U8a - only a simple p.length === 20 ? p : keccakAsU8a(secp256k1Expand(p))
2. the encodeaddress should use ethereumEncode

So effectively we will probably only have the line change in 1 as code-changes (for length 20, return as-is, else keep the status quo) and then your new tests to ensure it is working

[joelamouche]

Sounds good, I pushed a commit in that sens

[jacogr]

Looks good, just 2 small comments around reverting to the previous versions as indicated. Happy to merge after that, thank you.

[joelamouche]

Sounds good, updated

[jacogr]

Thank you!

[polkadot-js-bot]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.