-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make extension using Manifest V3 compatible with Firefox #1388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GH_RELEASE_FILES in CI needs to be updated :)
running |
Ah nvm thats intended |
yea |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR's goal is to make the extension compatible with Firefox, while still being compatible with the new
Manifest V3
introduced on #1367 .Changes
manifest_firefox.json
andmanifest_chrome.json
, with each containing the configuration for each browser. There's also a dummymanifest.json
which contents are modified depending on what's the target build. This is set like this to avoid the risk of getting an error in the build after modifying the name of the file and getting stuck. This way if the build is cut short, the only thing that changes is the content of the dummy manifest..zip
files names were updated to reflect the new targets:master-<TARGET_BROWSER>-build.zip
andmaster-<TARGET_BROWSER>-src.zip
.build
andbuild:zip
were updated to run the specific build scripts that were added for each target, in order to not break the CI, but now we can also build just the assets specific for the target browser we want or for both.README.md