Add LedgerGeneric support to the extension [WIP] #1397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
commented
Jul 16, 2024
| @@ -55,7 +52,9 @@ function retrieveLedger (genesis: string): Ledger { | |||
|
|
|||
| assert(def, 'There is no known Ledger app available for this chain'); | |||
|
|
|||
| ledger = new Ledger('webusb', def.network); | |||
| assert(def.slip44, 'Slip44 is not available for this network, please report an issue to update this chains slip44'); | |||
There was a problem hiding this comment.
The slip44 should always be polkadot for the LedgerGeneric wrapper
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This PR is going to require adding a new
getRawMetadatainterface to the extension in order to work with the new ledger metadataHash proof signing.My goal is to release the extension first to ensure we can get ledger support in apps. Then work on this immediately after.