Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Ledger Migration App #1422

Merged
merged 2 commits into from
Jul 29, 2024
Merged

feat: add support for Ledger Migration App #1422

merged 2 commits into from
Jul 29, 2024

Conversation

bee344
Copy link
Member

@bee344 bee344 commented Jul 29, 2024

This allows to select on the extension whether to use the Ledger Generic Polkadot App or the Ledger Migration App:
image

It also displays a warning when signing to alert the user of which app it's selected:
image

@bee344
Copy link
Member Author

bee344 commented Jul 29, 2024

There's this small space at the bottom that shows up when displaying the settings that is really annoying:
image

@bee344 bee344 requested a review from TarikGul July 29, 2024 15:42
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job, lgtm

@bee344 bee344 merged commit 324f66c into master Jul 29, 2024
3 checks passed
@bee344 bee344 deleted the anp-migration-app branch July 29, 2024 17:24
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants