Ability to Reject an authentication request instead of ignoring it #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikitayutanov please let me know if this helps |
Tbaut
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1431
This is not prefect, but it's a step in the right direction I believe.
When a user closes the authentication popup, nothing changes, the request is still here, it is still available in the extension on click. The icon also still shows that there's a pending "Auth" request. I don't think we've got any listener to act upon interaction with the popup, so I didn't mess with this.
Users however can now reject an authentication request. The Dapps will receive a "Reject" and no account will be shared. On the extension side, the connection will be made with 0 accounts and the Dapp that has called
web3Enable, and it will resolve with 0 accounts.