Keyboard added, input is handled

[aahutsal]

Basically it's partially finished for name TextInput, but I'd like to discuss keyboard flickering. According to this thread that won't be possible to fix for current React-Native version. Solution is to use custom controls in place of TextInput, but this would require more research and work. Please, lemme know.

[0xthreebody]

@agutsal Hey, Nice to see these. I will to try it. Really need a custom controls replacement TextInput.

[aahutsal]

@jiangfuyao this is another big task. I'm assured every custom control will hit Keyboard.arise() or whatever is the method name without an option to control that. We should a) either find out some which won't b) fork some open source control, fix that and maintain it.

I'd prefer to finish this one first (attach what we have to password items, fix some UI stuff) then close that project then start new one.

[0xthreebody]

@agutsal Now in the early stages of the project, use the a) solution first.

[aahutsal]

@jiangfuyao Check this: https://github.com/halilb/react-native-textinput-effects

Currently I'm checking how does they handle Keyboard.

[aahutsal]

@jiangfuyao solution above won't work as they use TextItem internally. This seems to be better one: https://github.com/themodernjavascript/react-native-custom-keyboard-kit

Since it was not requested initially to replace controls, don't you mind adding 100 DAI to current project, @jiangfuyao ?

I'm working on solution 2 now, hopefully will get it done by the end of the day.

[aahutsal]

@jiangfuyao #130 updated. Please try custom numeric keyboard for Name input. Let me know.

[aahutsal]

react-native-custom-keyboard-kit seems to be pretty buggy also. Unmaintainable and hardly use Java inside. Will let you try, then reverting back to old implementation and waiting you to discuss, @jiangfuyao

[0xthreebody]

react-native-custom-keyboard-kit is not a good implementation.

[aahutsal]

@jiangfuyao git push --force to previous one. I said - that's another big task to find the right approach/library. That was not planed from the beginning.

[aahutsal]

Reverted. I'll finish what we have now. Just wasted 5 hours today on react-native-custom-keyboard-kit, damn.

[0xthreebody]

Maybe this is good:
https://www.jianshu.com/p/6b6879323069
https://github.com/zhuanghongji/page/issues/7
https://github.com/lyxia/react-native-yusha-customKeyboard

[aahutsal]

@jiangfuyao lemme try their demo

[aahutsal]

@jiangfuyao this one works for me. Lemme add this implementation

[aahutsal]

@jiangfuyao #130 updated. Looks good to me (added to first input only yet)

[aahutsal]

@jiangfuyao thanks for that link btw ;)

[0xthreebody]

Now, full support for all inputs. Then I will check and merge. Thanks.

[aahutsal]

Key component and both passwords are now custom also, @jiangfuyao
Check it.

[0xthreebody]

Note: other pages also have the input box.

[aahutsal]

Noted. There are 49 more such entries. Since original project stated only password and private key inputs

I'd consider these 49 entries Phase II. Sounds fair?

[0xthreebody]

@agutsal The other pages only password need the safe keyboard.

[aahutsal]

@jiangfuyao check this one

[0xthreebody]

Tested good, but there have two small issue:

• The original keyboard has focus function, the custom keyboard has no focus function:

• Occasionally, a double keyboard appears. When using a computer keyboard input, it appears.

Note: If this fixed, I will merging these changes.

[aahutsal]

These both are related:
lyxia/react-native-yusha-customKeyboard#13

I can try using another repo for that component with that issue fixed, but we'll have system keyboard flickering again.

[aahutsal]

@jiangfuyao Check recent commit (CreateAccount screen). It's still not perfect, keyboard is flickering, but system keyboard gets dismissed once shown. As I already said there's no perfect solution on that ReactNative version. We should come to some agreement.

[aahutsal]

@jiangfuyao If you reviewed my recent commit I'd like to know your thoughts.

[0xthreebody]

@agutsal I will try it.

[aahutsal]

@jiangfuyao thx

[0xthreebody]

The 2th issue is fixed, but 1th not. On the android, the custom keyboard has no focus function.

[aahutsal]

@jiangfuyao I've found that component. Hopefully it will do what you need. Will buzz you once I update the code.

[aahutsal]

@jiangfuyao seems autofocus works now.

[0xthreebody]

@agutsal Testing...

[0xthreebody]

@agutsal Is nice, I will to merge this after resolved conflicts.

[aahutsal]

@jiangfuyao from what I see there are conflicting files. Conflicts are caused Windows CRLF symbol in the end of each line. Since that's Windows-only EOL symbol, Git suggests not to commit it. This could be changed with help from here. However, if you want to keep CRLF EOL symbol, I'll re-configure my git to add it to each line and will try merging again.

Let me know.

[0xthreebody]

@agutsal Keep it, and I'll delete it later version, thanks!

[aahutsal]

@jiangfuyao that's not correct decision. I've analyzed what have broken things and found, that your recent commit b4a3b0b (that' merged PR #135) did so.
PR #135 has 18k changed lines, not because it's super cool mega commit, but because its author(s) has changed CR to CRLF everywhere in codebase. I'm wondered how git pre-commit hook (that use husky that required lint npm script execution allowed so), perhaps husky was just temporarily switched off by committer, otherwise it would --fix all sources, replacing CRLF back to CR everywhere. Now, if I follow your commands we would have problems. I'd suggest to reset to 0d282ef (reverting #135 PR), push --force then fix #135 and merge it back. Then I can easily push my changes.

If not - everyone who is currently working on your code will have the same problems I have now.

[0xthreebody]

@agutsal I changed EOL from CRLF to LF, #137
this is your master branch to pull polkawallet-RN fix-eol branch, just for test. Is it ok now? Only can use CR?

[aahutsal]

Trying. Will let you know shortly @jiangfuyao

[aahutsal]

@jiangfuyao that was a nice talk. I'm closing that pull request, patched recent origin/fix-eol branch and created new PR