Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI test case for polkit - systemd integration #439

Closed
msekletar opened this issue Mar 20, 2024 · 4 comments
Closed

Add CI test case for polkit - systemd integration #439

msekletar opened this issue Mar 20, 2024 · 4 comments
Assignees

Comments

@msekletar
Copy link

Is your feature request related to a problem? Please describe.
This RFE is motivated by #206.

Describe the solution you'd like
Simple automated test (something along the lines of reproducer from #206) for this use-case to prevent future regressions.

Describe alternatives you've considered
I think this functionality should be tested in upstream but in case this request can't be fulfilled for any reason I will seek solution on distribution level (Fedora).

Additional context
Polkit rules for systemd unit management are often used feature and it would be great to have test coverage for it in upstream CI.

@jrybar-rh jrybar-rh assigned jrybar-rh and bluca and unassigned jrybar-rh Mar 24, 2024
@jrybar-rh
Copy link
Member

Hello @bluca,
Can you cover this, please?

@bluca
Copy link
Member

bluca commented Mar 24, 2024

There's no test infrastructure in place to do anything like that, it would be a huge task and I'm afraid I just don't have the time for that, sorry

@jrybar-rh
Copy link
Member

Ok, from what I've seen in monitoring of dbus, it looks like the dbusmock needs to be updated to provide response for the new GetConnectionCredentials method. I'm exploring the dbusmock settings right now.

mrc0mmand added a commit to mrc0mmand/polkit that referenced this issue Jun 6, 2024
Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to TestingFarm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for polkit-org#439.

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
mrc0mmand added a commit to mrc0mmand/polkit that referenced this issue Jun 6, 2024
Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to TestingFarm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for polkit-org#439.

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
mrc0mmand added a commit to mrc0mmand/polkit that referenced this issue Jun 6, 2024
Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to TestingFarm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for polkit-org#439.

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
mrc0mmand added a commit to mrc0mmand/polkit that referenced this issue Jun 6, 2024
Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to TestingFarm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for polkit-org#439.

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
mrc0mmand added a commit to mrc0mmand/polkit that referenced this issue Jun 6, 2024
Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to Testing Farm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for polkit-org#439 (that I plan to extend further shortly).

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
mrc0mmand added a commit to mrc0mmand/polkit that referenced this issue Jun 6, 2024
Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to Testing Farm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for polkit-org#439 (that I plan to extend further shortly).

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
mrc0mmand added a commit to mrc0mmand/polkit that referenced this issue Jun 6, 2024
Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to Testing Farm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for polkit-org#439 (that I plan to extend further shortly).

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
mrc0mmand added a commit to mrc0mmand/polkit that referenced this issue Jun 6, 2024
Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to Testing Farm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for polkit-org#439 (that I plan to extend further shortly).

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
mrc0mmand added a commit to mrc0mmand/polkit that referenced this issue Jun 7, 2024
Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to Testing Farm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for polkit-org#439.

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
mrc0mmand added a commit to mrc0mmand/polkit that referenced this issue Jun 7, 2024
Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to Testing Farm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for polkit-org#439.

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
mrc0mmand added a commit to mrc0mmand/polkit that referenced this issue Jun 7, 2024
Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to Testing Farm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for polkit-org#439.

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
mrc0mmand added a commit to mrc0mmand/polkit that referenced this issue Jun 7, 2024
Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to Testing Farm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for polkit-org#439.

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
jrybar-rh pushed a commit that referenced this issue Jun 10, 2024
* ci: build on alt-archs as well

* test: introduce an integration test suite

Since we already use Packit, let's utilize its second part as well and
add a TMT [0] based integration test suite.

This PR add a second job to the existing Packit configuration, which
then sends the just built RPMs to Testing Farm [1] that executes all
selected tests (which currently means all discovered tests).

To demonstrate the functionality a bit, this PR also adds a simple test
case for #439.

[0] https://tmt.readthedocs.io/en/stable/overview.html
[1] https://docs.testing-farm.io/Testing%20Farm/0.1/index.html
@jrybar-rh
Copy link
Member

jrybar-rh commented Jun 10, 2024

Fixed in f510b3f

Thanks, @mrc0mmand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants