Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_get_package_readme fails when it is called with package name without Pollination #68

Closed
mostaphaRoudsari opened this issue Feb 12, 2021 · 1 comment · Fixed by #70
Closed

_get_package_readme fails when it is called with package name without Pollination #68

mostaphaRoudsari opened this issue Feb 12, 2021 · 1 comment · Fixed by #70
Labels
Bug 🐛 Something isn't working Good first issue 👶 Good for newcomers P2-Important: ⚠️ released

Comments

@mostaphaRoudsari
Copy link
Member

I didn't notice this so far as all the plugins already have a package with no pollination in the front. This is an easy fix by adding package_name = name_to_pollination(package_name) to line 135 in common.py
@mostaphaRoudsari mostaphaRoudsari added Bug 🐛 Something isn't working Good first issue 👶 Good for newcomers P2-Important: ⚠️ labels Feb 12, 2021
mostaphaRoudsari added a commit to mostaphaRoudsari/queenbee-python-dsl that referenced this issue Feb 13, 2021
@mostaphaRoudsari
fix(package metadata): ensure package name is fixed
8233ad5 
Resolves pollination#68
@mostaphaRoudsari mostaphaRoudsari linked a pull request Feb 13, 2021 that will close this issue
fix small bugs #70
Merged
mostaphaRoudsari added a commit that referenced this issue Feb 13, 2021
@mostaphaRoudsari
fix(package metadata): ensure package name is fixed
725fa0a 
Resolves #68
@github-actions
Copy link

🎉 This issue has been resolved in version 0.9.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛 Something isn't working Good first issue 👶 Good for newcomers P2-Important: ⚠️ released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix small bugs mostaphaRoudsari/queenbee-python-dsl
1 participant
@mostaphaRoudsari