Keep i2c error as bit flag which TwoWire::endTransmission() returns #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last_status is reasonable solution to get the last status of i2c trnasmittion, but in some cases, the last_status is overwritten by calling read/write register API more than once. For instance, init(), startContinuous(), etc. Especially on Arduino IDE 1.8.13, new error code `5` (i2c timeout) is added to Wire.endTransmission() by merging this PR arduino/ArduinoCore-avr#107 . You can distinguish what error occurs and use them depending on the situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last_status is reasonable solution to get the last status of i2c
trnasmittion, but in some cases, the last_status is overwritten by
calling read/write register API more than once. For instance, init(),
startContinuous(), etc.
Especially on Arduino IDE 1.8.13, new error code
5(i2c timeout) isadded to Wire.endTransmission() by merging this PR
arduino/ArduinoCore-avr#107 .
You can distinguish what error occurs and use them depending on the
situation.