-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added .ini extension check to default config #2324
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2324 +/- ##
=========================================
- Coverage 7.89% 7.89% -0.01%
=========================================
Files 142 142
Lines 10219 10225 +6
=========================================
Hits 807 807
- Misses 9412 9418 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that was really fast. Thanks 😃
I think this slightly changes (in a backwards incompatible way) how config files are loaded.
Before, if $XDG_CONFIG_HOME/polybar/config
didn't exist (but the env variable did), it would try $HOME/.config/polybar/config
, now the function directly returns an empty string.
Please also add these changes to the changelog (https://github.com/polybar/polybar/blob/master/CONTRIBUTING.md#changelog)
These changes also need to be reflected in doc/man/polybar.5.rst
, in the first section.
Ah I see what you mean. It looks like I might've went wrong there when refactoring the code. I will go ahead and fix this
Sorry, I forgot to do that 😅. I will upload the changes shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Looks like it works now :)
Please remove the extra newlines in CHANGELOG.md
again and I'll merge this.
CHANGELOG.md
Outdated
@@ -1,4 +1,5 @@ | |||
# Changelog | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lack of newlines was intentional because that's also how keep a changelog does it. Please remove them again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, my IDE most likely auto formatted it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought as much ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks a lot 🚀
What type of PR is this? (check all applicable)
Description
Loads
config.ini
ifconfig
could not be found.Related Issues & Documents
Closes #2323