Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automatic code generation tools #2

Closed
10 tasks done
acloudiator opened this issue Dec 17, 2018 · 1 comment
Closed
10 tasks done

Update automatic code generation tools #2

acloudiator opened this issue Dec 17, 2018 · 1 comment

Comments

@acloudiator
Copy link
Contributor

acloudiator commented Dec 17, 2018

https://github.com/polycube-network/swagger-codegen/ is behind last changes we did to polycube.

AFAIK this as the missing changes:

  • Ports constructor
  • Ports::{create, get, getEntry, remove, removeEntry}
  • packet_in signature
  • remove TYPE_ from TYPE_{TC, XDP_SKB, XDP_DRV}
  • egress_code argument always required in Cube constructor
  • Cube is templated: cube inherits from Cube
  • ports_ is not anymore present on service class (not sure if this is part of the code generator)
  • CMakeList.txt on src/
  • create service_dp.c instead of service_dp.h
  • do not include datamodel in service-lib.cpp

Probably we should adopt a policy that a PR that affects code generation cannot be merged into polycube until the generation tools are updated

  • Mauricio
@mauriciovasquezbernal
Copy link
Contributor

ekoops added a commit to ekoops/polycube that referenced this issue Dec 27, 2021
ekoops added a commit to ekoops/polycube that referenced this issue Dec 27, 2021
ekoops added a commit to ekoops/polycube that referenced this issue Dec 27, 2021
ekoops added a commit to ekoops/polycube that referenced this issue Dec 27, 2021
ekoops added a commit to ekoops/polycube that referenced this issue Dec 28, 2021
ekoops added a commit to ekoops/polycube that referenced this issue Dec 28, 2021
ekoops added a commit to ekoops/polycube that referenced this issue Dec 28, 2021
ekoops added a commit to ekoops/polycube that referenced this issue Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants