Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Dynmon service enhancements #291

Closed
5 tasks done
smagnani96 opened this issue Apr 23, 2020 · 1 comment
Closed
5 tasks done

[Feature Request] Dynmon service enhancements #291

smagnani96 opened this issue Apr 23, 2020 · 1 comment
Labels
Feature Request

Comments

@smagnani96
Copy link
Contributor

smagnani96 commented Apr 23, 2020 •
edited
Loading

Background

Recently, I have been using the new Dynmon service to test dynamic code injection and metrics extraction. Everything works as expected, but I would like to propose some enhancements that could increase the usability and customization of that service.

Suggestions

The main innovations that came up to are the following:

  • Introduce support for the egress dataplane path (Dynmon v1.1 #311)
  • Introduce key exporting feature (for hash-based type maps) (Dynmon enhancement - Key export feature #303)
  • Introduce fields inside an accepted metric to decide whether once the map associated to that metric is exported should be emptied or not (Dynmon v1.1 #311 )
  • Introduce duplication of the map requested by the user not only to speed up metric extraction, but also to avoid dataplane to be stuck waiting for the map's lock to be released by controlplane (Dynmon v1.1 #311 )
  • Enlarge Dynmon map extraction support, allowing reading:
  • Queue/Stack
  • Array types
  • Hash types
  • PerCPU types

The last one is the less essential, since it is not strictly related to the parameterization of the service, but to his performance.
smagnani96 added a commit to smagnani96/polycube that referenced this issue May 13, 2020
@smagnani96
Dynmon enhancement - Key export feature
4c2bc0f 
This commit addresses the 2nd point discussed in polycube-network#291.
It has been introduced the key extraction, meaning that if the bpf map is a
key-value type one, not only the value is exported, but also the associated key.

Still, for map-in-map types there is not full support yet, due to many problem related to
the map info retrieval.

Signed-off-by: Simone Magnani <simonemagnani.96@gmail.com>
smagnani96 added a commit to smagnani96/polycube that referenced this issue May 13, 2020
@smagnani96
Dynmon enhancement - Key export feature
b88cb42 
This commit addresses the 2nd point discussed in polycube-network#291.
It has been introduced the key extraction, meaning that if the bpf map is a
key-value type one, not only the value is exported, but also the associated key.

Still, for map-in-map types there is not full support yet, due to many problem related to
the map info retrieval.

Signed-off-by: Simone Magnani <simonemagnani.96@gmail.com>
@smagnani96 smagnani96 mentioned this issue May 13, 2020
Merged
smagnani96 added a commit to smagnani96/polycube that referenced this issue May 14, 2020
@smagnani96
Dynmon enhancement - Key export feature
0f640a2 
This commit addresses the 2nd point discussed in polycube-network#291.
It has been introduced the key extraction, meaning that if the bpf map is a
key-value type one, not only the value is exported, but also the associated key.

Still, for map-in-map types there is not full support yet, due to many problem related to
the map info retrieval.

Signed-off-by: Simone Magnani <simonemagnani.96@gmail.com>
@smagnani96
Copy link
Contributor Author

#311 and #312 have introduced all the features, this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smagnani96